From: Pete Wyckoff <pw@padd.com>
To: Vitor Antunes <vitor.hda@gmail.com>
Cc: git@vger.kernel.org, Tor Arvid Lund <torarvid@gmail.com>
Subject: Re: [PATCH v3 0/4] git-p4: Improve branch support
Date: Fri, 19 Aug 2011 04:53:10 -0700 [thread overview]
Message-ID: <20110819115310.GC15639@padd.com> (raw)
In-Reply-To: <1313711046-23489-1-git-send-email-vitor.hda@gmail.com>
vitor.hda@gmail.com wrote on Fri, 19 Aug 2011 00:44 +0100:
> Add missing test case from last version of this set of patches.
>
> Vitor Antunes (4):
> git-p4: Correct branch base depot path detection
> git-p4: Allow filtering Perforce branches by user
> git-p4: Allow branch definition with git config
> git-p4: Add simple test case for branch import
>
> contrib/fast-import/git-p4 | 40 ++++++++++++++++++++++--
> contrib/fast-import/git-p4.txt | 13 ++++++++
> t/t9800-git-p4.sh | 64 ++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 113 insertions(+), 4 deletions(-)
Patches 1 and 2 are great. We should have gotten those in way
back when you first submitted them. I happily ack those.
I'm still a bit hung up on #3, mainly because I don't get branch
support. Let me play around with your test. Having this
playbook of how it is supposed to work will help to educate me.
-- Pete
next prev parent reply other threads:[~2011-08-19 11:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-18 23:44 [PATCH v3 0/4] git-p4: Improve branch support Vitor Antunes
2011-08-18 23:44 ` [PATCH v3 1/4] git-p4: Correct branch base depot path detection Vitor Antunes
2011-08-18 23:44 ` [PATCH v3 2/4] git-p4: Allow filtering Perforce branches by user Vitor Antunes
2011-08-18 23:44 ` [PATCH v3 3/4] git-p4: Allow branch definition with git config Vitor Antunes
2011-08-18 23:44 ` [PATCH v3 4/4] git-p4: Add simple test case for branch import Vitor Antunes
2011-08-20 19:11 ` Pete Wyckoff
2011-08-19 11:53 ` Pete Wyckoff [this message]
2011-08-19 14:30 ` [PATCH v3 0/4] git-p4: Improve branch support Vitor Antunes
2011-08-20 19:14 ` Pete Wyckoff
2011-08-23 22:32 ` Vitor Antunes
2011-08-19 18:02 ` Junio C Hamano
2011-08-19 18:23 ` Vitor Antunes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110819115310.GC15639@padd.com \
--to=pw@padd.com \
--cc=git@vger.kernel.org \
--cc=torarvid@gmail.com \
--cc=vitor.hda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.