From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: convert dm-thin to use dm-bufio Date: Fri, 19 Aug 2011 10:11:46 -0400 Message-ID: <20110819141146.GC1335@redhat.com> References: <20110815090416.GE3159@ubuntu> <20110816091600.GA4284@ubuntu> <20110817082656.GA3267@ubuntu> <20110819070435.GA32300@redhat.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: device-mapper development Cc: Joe Thornber , "Alasdair G. Kergon" List-Id: dm-devel.ids On Fri, Aug 19 2011 at 9:31am -0400, Mikulas Patocka wrote: > On Fri, 19 Aug 2011, Mike Snitzer wrote: > > > On Thu, Aug 18 2011 at 6:31pm -0400, > > Mikulas Patocka wrote: > > > > > > This all sounds good; get the locking interface in and I'll switch to > > > > bufio straight away. > > > > > > > > - Joe > > > > > > I uploaded bufio-based block manager at > > > http://people.redhat.com/mpatocka/patches/kernel/dm-thinp-bufio/. It > > > supports locks, but it defines new functions down_write_non_owner and > > > up_write_non_owner. > > > > dm-bufio.patch: > > drivers/md/Kconfig needs a more comprehensive description for DM_BUFIO's > > help. > > There is intentionally no description. If there is no description, this > option won't appear in "make menuconfig" menu. > > dm-bufio is selected automatically when some module that needs it is > configured. There is no need to select dm-bufio manually. Hmm, I wonder if it makes sense to remove DM_PERSISTENT_DATA's help description? (we already select DM_PERSISTENT_DATA when DM_THIN_PROVISIONING is selected -- but it is visible in menuconfig because it has a description).