From: Joe Thornber <thornber@redhat.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: dm-devel@redhat.com, "Alasdair G. Kergon" <agk@redhat.com>,
Mike Snitzer <snitzer@redhat.com>
Subject: Re: convert dm-thin to use dm-bufio
Date: Fri, 19 Aug 2011 16:37:07 +0100 [thread overview]
Message-ID: <20110819153706.GA23736@ubuntu> (raw)
In-Reply-To: <Pine.LNX.4.64.1108190926530.2592@hs20-bc2-1.build.redhat.com>
On Fri, Aug 19, 2011 at 09:31:56AM -0400, Mikulas Patocka wrote:
> On Fri, 19 Aug 2011, Mike Snitzer wrote:
> > -struct dm_block;
> > +#define dm_block dm_buffer
> > +#define dm_block_manager dm_bufio_client
> >
> > But I think it'd be best, in the long run, to have a follow-on patch
> > that does away with the aliases and just use the bufio structs
> > throughout the code. Anyway, don't need to worry about this now. But
> > what you've done is hack that should probably be cleaned up.
>
> This way, it's easy to swap the original block manager and dm-bufio.
>
> If I changed the names throughout the whole dm-thinp code, it would
> conflict with any changes Joe may do.
I agree with Mikulas here.
next prev parent reply other threads:[~2011-08-19 15:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-14 20:18 [PATCHES] convert dm-thin to use dm-bufio Mikulas Patocka
2011-08-15 9:04 ` Joe Thornber
2011-08-15 18:26 ` Mikulas Patocka
2011-08-16 9:16 ` Joe Thornber
2011-08-16 22:03 ` Mikulas Patocka
2011-08-17 8:26 ` Joe Thornber
2011-08-18 22:31 ` Mikulas Patocka
2011-08-19 7:04 ` Mike Snitzer
2011-08-19 9:11 ` Joe Thornber
2011-08-19 9:46 ` Mike Snitzer
2011-08-19 10:17 ` Mike Snitzer
2011-08-19 10:22 ` Joe Thornber
2011-08-19 13:49 ` Mike Snitzer
2011-08-19 14:11 ` Alasdair G Kergon
2011-08-19 13:31 ` Mikulas Patocka
2011-08-19 14:11 ` Mike Snitzer
2011-08-19 15:37 ` Joe Thornber [this message]
2011-08-19 18:25 ` Mike Snitzer
2011-08-19 18:50 ` Alasdair G Kergon
2011-08-19 9:12 ` [PATCHES] " Joe Thornber
2011-08-19 16:17 ` Joe Thornber
2011-08-20 1:10 ` [PATCH 1/2] dm bufio: fix "value computed is not used" warnings Mike Snitzer
2011-08-20 1:10 ` [PATCH 2/2] dm space map: only include bitops.h in dm-space-map-common.c Mike Snitzer
2011-08-22 13:29 ` [PATCH 1/2] dm bufio: fix "value computed is not used" warnings Mikulas Patocka
2011-08-22 18:24 ` [PATCHES] convert dm-thin to use dm-bufio Mikulas Patocka
2011-08-22 19:59 ` Mikulas Patocka
2011-08-23 11:23 ` Joe Thornber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110819153706.GA23736@ubuntu \
--to=thornber@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=mpatocka@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.