From: scameron@beardog.cce.hp.com
To: Douglas Gilbert <dgilbert@interlog.com>
Cc: james.bottomley@hansenpartnership.com, stephenmcameron@gmail.com,
akpm@linux-foundation.org, gregkh@suse.de,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: Document generic scsi device attributes
Date: Fri, 19 Aug 2011 10:41:35 -0500 [thread overview]
Message-ID: <20110819154135.GF8422@beardog.cce.hp.com> (raw)
In-Reply-To: <4E4E7F8B.7020502@interlog.com>
On Fri, Aug 19, 2011 at 11:21:47AM -0400, Douglas Gilbert wrote:
> On 11-08-19 10:44 AM, Stephen M. Cameron wrote:
> >From: Stephen M. Cameron<scameron@beardog.cce.hp.com>
> >
>
> <snip>
>
> >+What: /sys/class/scsi_device/..../device/modalias
> >+Date: April, 2007
> >+KernelVersion: Unknown
> >+Contact: James Bottomley<James.Bottomley@HansenPartnership.com>
> >+Description:
> >+ This read only string value contains a string of the form
> >+ "scsi:t-0xXX" where "XX" are two hex digits representing the
> >+ SCSI device type. See also the "type" attribute and table 47
> >+ in section 8.2.5.1 "Standard INQUIRY data" of the SCSI-2
> >+ specification.
>
> My copy of SCSI-2 is draft 10b from 1989 and it doesn't have a
> section 8.2.5.1 . Since SCSI-2 was withdrawn over 10 years
> ago perhaps you could use a more recent reference. [I see
> webstore.ansi.org still sells the SCSI-2 standard for $30 .]
>
> SPC-3 is a standard [ANSI INCITS 408-2005; ISO/IEC 14776-453]
> and the relevant section, judging from its last draft, would
> be table 83 in section 6.4.2 . And it is now called the
> "peripheral device type".
I knew it was a mistake for me to try to figure out what the
proper reference should be. If such things change, maybe
having a reference in there at all is a mistake. Maybe it should just
say something like, "the numbers correspond to the entries in
the scsi_device_types[] array in drivers/scsi/scsi.c" since
that file is more likely to be close at hand than whichever
spec we might refer to.
-- steve
next prev parent reply other threads:[~2011-08-19 15:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-19 14:44 [PATCH] scsi: Document generic scsi device attributes Stephen M. Cameron
2011-08-19 15:21 ` Douglas Gilbert
2011-08-19 15:41 ` scameron [this message]
2011-08-21 16:22 ` Stefan Richter
-- strict thread matches above, loose matches on Subject: below --
2011-08-17 18:20 Stephen M. Cameron
2011-08-17 19:45 ` James Bottomley
2011-08-17 20:00 ` scameron
2011-08-17 20:35 ` James Bottomley
2011-08-18 12:47 ` Stefan Richter
2011-08-18 12:58 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110819154135.GF8422@beardog.cce.hp.com \
--to=scameron@beardog.cce.hp.com \
--cc=akpm@linux-foundation.org \
--cc=dgilbert@interlog.com \
--cc=gregkh@suse.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stephenmcameron@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.