All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Andi Kleen <ak@linux.intel.com>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	hch@infradead.org, Jens Axboe <jaxboe@fusionio.com>
Subject: Re: [PATCH 10/11] VFS: Cache request_queue in struct block_device
Date: Fri, 19 Aug 2011 12:51:01 -0400	[thread overview]
Message-ID: <20110819165101.GA13862@redhat.com> (raw)
In-Reply-To: <20110819162312.GE25996@one.firstfloor.org>

On Fri, Aug 19, 2011 at 06:23:12PM +0200, Andi Kleen wrote:
> > Primarily because of code complexity. We are stashing away a pointer and
> > not taking any reference anywhere. So I am not even sure who is making
> > sure that request queue is not gone and there are no comments in the code
> > about why we are stashing a pointer and how are we making sure that
> > request queue is around for the lifetime of bdev.
> 
> Can you point out a concrete problem in my approach?  This seems
> rather vague.

I am not saying that there is a problem in your approach. I am just
asking or trying to understand that who makes sure request queue is
not gone. 

So if you could just comment two things in code it will help for
a futuer reader of the code.

- Why are we stashing this extra pointer.
- What makes sure that object pointed by this pointer is not freed.

I am not saying that there is a problem. Just that I don't know enough
of code to understand how we are making sure queue object is still
around.

Thanks
Vivek

  reply	other threads:[~2011-08-19 16:51 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-02  4:38 Updated direct IO optimization patchkit v2 Andi Kleen
2011-08-02  4:38 ` [PATCH 01/11] DIO: Separate fields only used in the submission path from struct dio Andi Kleen
2011-08-08 17:59   ` Jeff Moyer
2011-08-08 19:43     ` Andi Kleen
2011-08-08 19:46       ` Jeff Moyer
2011-08-02  4:38 ` [PATCH 02/11] DIO: Fix a wrong comment Andi Kleen
2011-08-08 17:59   ` Jeff Moyer
2011-08-02  4:38 ` [PATCH 03/11] DIO: Rearrange fields in dio/dio_submit to avoid holes Andi Kleen
2011-08-08 18:00   ` Jeff Moyer
2011-08-02  4:38 ` [PATCH 04/11] DIO: Use a slab cache for struct dio Andi Kleen
2011-08-08 18:01   ` Jeff Moyer
2011-08-02  4:38 ` [PATCH 05/11] DIO: Separate map_bh from dio v2 Andi Kleen
2011-08-08 18:11   ` Jeff Moyer
2011-08-02  4:38 ` [PATCH 06/11] DIO: Inline the complete submission path v2 Andi Kleen
2011-08-08 18:14   ` Jeff Moyer
2011-08-02  4:38 ` [PATCH 07/11] DIO: Merge direct_io_walker into __blockdev_direct_IO Andi Kleen
2011-08-08 18:20   ` Jeff Moyer
2011-08-02  4:38 ` [PATCH 08/11] DIO: Remove unnecessary dio argument from dio_pages_present() Andi Kleen
2011-08-08 18:21   ` Jeff Moyer
2011-08-02  4:38 ` [PATCH 09/11] DIO: Remove unused dio parameter from dio_bio_add_page Andi Kleen
2011-08-08 18:21   ` Jeff Moyer
2011-08-02  4:38 ` [PATCH 10/11] VFS: Cache request_queue in struct block_device Andi Kleen
2011-08-08 18:22   ` Jeff Moyer
2011-08-18 19:42   ` Vivek Goyal
2011-08-18 21:03     ` Andi Kleen
2011-08-19 14:14       ` Vivek Goyal
2011-08-19 15:36         ` Andi Kleen
2011-08-19 15:55           ` Vivek Goyal
2011-08-19 16:23             ` Andi Kleen
2011-08-19 16:51               ` Vivek Goyal [this message]
2011-08-02  4:38 ` [PATCH 11/11] DIO: optimize cache misses in the submission path Andi Kleen
2011-08-08 18:43   ` Jeff Moyer
2011-08-08 19:32     ` Andi Kleen
2011-08-08 19:38       ` Jeff Moyer
2011-08-18 17:53 ` Updated direct IO optimization patchkit v2 Jeff Moyer
  -- strict thread matches above, loose matches on Subject: below --
2011-08-29 23:23 Updated direct IO optimization patchkit v3 Andi Kleen
2011-08-29 23:23 ` [PATCH 10/11] VFS: Cache request_queue in struct block_device Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110819165101.GA13862@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=hch@infradead.org \
    --cc=jaxboe@fusionio.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.