All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pete Wyckoff <pw@padd.com>
To: Vitor Antunes <vitor.hda@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org, Tor Arvid Lund <torarvid@gmail.com>
Subject: Re: [PATCH v2 1/4] git-p4: Allow setting rename/copy detection threshold.
Date: Sat, 20 Aug 2011 07:19:56 -0400	[thread overview]
Message-ID: <20110820111956.GA5893@arf.padd.com> (raw)
In-Reply-To: <CAOpHH-WJWxeTSO5Dy6UR9pJh3w9hQSBuE7O1mY2KDAEsS9OAPw@mail.gmail.com>

vitor.hda@gmail.com wrote on Fri, 19 Aug 2011 14:51 +0100:
> On Fri, Aug 19, 2011 at 12:47 PM, Pete Wyckoff <pw@padd.com> wrote:
> > I think you have to decide that 1 means 1 in this case.
> > Everything else can mean true.  That may suggest that using
> > --bool or --bool-or-int isn't possible in this case.
> 
> But doing that kind of post-processing would require me to call
> git-config (at least) twice: first to check if it is a number with a
> possible "." in the middle or "%" at the end and a second time with
> the --bool option. I have no problem in doing this, but I think it
> increases the complexity without bringing major advantages.
> 
> I will use --bool for detectCopiesHarder and will send you the new set
> of patches tonight, unless we decide to also start using it for
> detectCopies and detectRenames.

I was imagining you would not use "--bool", and parse everything
yourself.  But I see your point, and letting "1" mean "-M1" as
opposed to "-M" is probably okay too.  I'm not particularly
worked up about which way that goes.

		-- Pete

  reply	other threads:[~2011-08-20 14:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-18 22:20 [PATCH v2 0/4] Support threshold in copy/rename detection Vitor Antunes
2011-08-18 22:20 ` [PATCH v2 1/4] git-p4: Allow setting rename/copy detection threshold Vitor Antunes
2011-08-18 23:04   ` Junio C Hamano
2011-08-18 23:43     ` Vitor Antunes
2011-08-19 11:47       ` Pete Wyckoff
2011-08-19 13:51         ` Vitor Antunes
2011-08-20 11:19           ` Pete Wyckoff [this message]
2011-08-22  0:09             ` Vitor Antunes
2011-08-18 22:20 ` [PATCH v2 2/4] git-p4: Add description of rename/copy detection options Vitor Antunes
2011-08-18 22:20 ` [PATCH v2 3/4] git-p4: Add test case for rename detection Vitor Antunes
2011-08-18 22:20 ` [PATCH v2 4/4] git-p4: Add test case for copy detection Vitor Antunes
2011-08-20 19:09 ` [PATCH v2 0/4] Support threshold in copy/rename detection Pete Wyckoff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110820111956.GA5893@arf.padd.com \
    --to=pw@padd.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=torarvid@gmail.com \
    --cc=vitor.hda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.