All of lore.kernel.org
 help / color / mirror / Atom feed
From: matt mooney <mfm@muteddisk.com>
To: Akshay Joshi <me@akshayjoshi.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
	linux-usb@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Staging: usbip: Fix braces and spaces to match coding style.
Date: Sat, 20 Aug 2011 23:57:25 -0700	[thread overview]
Message-ID: <20110821065725.GB27006@haskell.muteddisk.com> (raw)
In-Reply-To: <1313611112-16083-2-git-send-email-me@akshayjoshi.com>

On 15:58 Wed 17 Aug     , Akshay Joshi wrote:
> Fix brace positioning and spaces at the start of lines in order to
> comply with the kernel coding style.
> 
> Signed-off-by: Akshay Joshi <me@akshayjoshi.com>

Acked-by: matt mooney <mfm@muteddisk.com>

> ---
>  drivers/staging/usbip/stub_dev.c |    2 +-
>  drivers/staging/usbip/stub_rx.c  |    3 +--
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/usbip/stub_dev.c b/drivers/staging/usbip/stub_dev.c
> index 1dacdc0..77d6469 100644
> --- a/drivers/staging/usbip/stub_dev.c
> +++ b/drivers/staging/usbip/stub_dev.c
> @@ -548,4 +548,4 @@ struct usb_driver stub_driver = {
>  	.id_table	= stub_table,
>  	.pre_reset	= stub_pre_reset,
>  	.post_reset	= stub_post_reset,
> - };
> +};
> diff --git a/drivers/staging/usbip/stub_rx.c b/drivers/staging/usbip/stub_rx.c
> index 1c1957f..6b4e3e1 100644
> --- a/drivers/staging/usbip/stub_rx.c
> +++ b/drivers/staging/usbip/stub_rx.c
> @@ -179,8 +179,7 @@ static int tweak_reset_device_cmd(struct urb *urb)
>  	 * longer unbinds. This allows the use of synchronous reset.
>  	 */
>  
> -	if (usb_lock_device_for_reset(sdev->udev, sdev->interface)<0)
> -	{
> +	if (usb_lock_device_for_reset(sdev->udev, sdev->interface) < 0) {
>  		dev_err(&urb->dev->dev, "could not obtain lock to reset device\n");
>  		return 0;
>  	}
> -- 
> 1.7.5.4
> 

  reply	other threads:[~2011-08-21  7:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-17 19:58 [PATCH 1/2] Staging: usbip: Remove trailing spaces Akshay Joshi
2011-08-17 19:58 ` [PATCH 2/2] Staging: usbip: Fix braces and spaces to match coding style Akshay Joshi
2011-08-21  6:57   ` matt mooney [this message]
2011-08-21  6:56 ` [PATCH 1/2] Staging: usbip: Remove trailing spaces matt mooney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110821065725.GB27006@haskell.muteddisk.com \
    --to=mfm@muteddisk.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=me@akshayjoshi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.