From: Austin Clements <amdragon@MIT.EDU>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] monitor: Prevent sign-extension of 32-bit addresses printed by info mem
Date: Sun, 21 Aug 2011 14:48:38 -0400 [thread overview]
Message-ID: <20110821184838.GP21339@mit.edu> (raw)
In-Reply-To: <CAAu8pHsUv0z03D-ZFrHUmquX6yNgFi_6zLThbGN06bPJqh-gtA@mail.gmail.com>
Quoth Blue Swirl on Aug 21 at 6:26 pm:
> On Mon, Aug 15, 2011 at 3:19 AM, Austin Clements <amdragon@mit.edu> wrote:
> > Previously, on 32-bit i386, info mem used signed 32-bit int's to store
> > the page table indexes. As a result, address calculation was done in
> > 32 bits and then incorrectly sign-extended to 64 bits, yielding output
> > like
> >
> > ffffffffef000000-ffffffffef031000 0000000000031000 ur-
> > ffffffffef7bc000-ffffffffef7bd000 0000000000001000 urw
> > ffffffffef7bd000-ffffffffef7be000 0000000000001000 ur-
> >
> > This makes these indexes unsigned, which yields correct output
> >
> > 00000000ef000000-00000000ef031000 0000000000031000 ur-
> > 00000000ef7bc000-00000000ef7bd000 0000000000001000 urw
> > 00000000ef7bd000-00000000ef7be000 0000000000001000 ur-
> >
> > Signed-off-by: Austin Clements <amdragon@mit.edu>
>
> Thanks, applied. I think 'info tlb' needs a similar fix.
Quite right. I'll follow up with the info tlb patch.
next prev parent reply other threads:[~2011-08-21 18:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-15 3:19 [Qemu-devel] [PATCH] monitor: Prevent sign-extension of 32-bit addresses printed by info mem Austin Clements
2011-08-21 18:26 ` Blue Swirl
2011-08-21 18:48 ` Austin Clements [this message]
2011-08-21 18:49 ` [Qemu-devel] [PATCH] monitor: Prevent sign-extension of 32-bit addresses printed by info tlb Austin Clements
2011-08-21 19:51 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110821184838.GP21339@mit.edu \
--to=amdragon@mit.edu \
--cc=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.