All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: Witold.Szczeponik@gmx.net
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: 'flags' in rsparser.c change from 'register disabled resources' patch
Date: Mon, 22 Aug 2011 01:59:02 +0100	[thread overview]
Message-ID: <20110822005902.GA30602@gallifrey> (raw)

Hi Witold,
  'sparse' is giving me the following set of warnings in the latest
kernel:

  CHECK   drivers/pnp/pnpacpi/rsparser.c
drivers/pnp/pnpacpi/rsparser.c:515:26: warning: cast truncates bits from constant value (10000000 becomes 0)
drivers/pnp/pnpacpi/rsparser.c:533:26: warning: cast truncates bits from constant value (10000000 becomes 0)
drivers/pnp/pnpacpi/rsparser.c:553:26: warning: cast truncates bits from constant value (10000000 becomes 0)
drivers/pnp/pnpacpi/rsparser.c:578:26: warning: cast truncates bits from constant value (10000000 becomes 0)
drivers/pnp/pnpacpi/rsparser.c:593:26: warning: cast truncates bits from constant value (10000000 becomes 0)
drivers/pnp/pnpacpi/rsparser.c:606:26: warning: cast truncates bits from constant value (10000000 becomes 0)
drivers/pnp/pnpacpi/rsparser.c:621:26: warning: cast truncates bits from constant value (10000000 becomes 0)
drivers/pnp/pnpacpi/rsparser.c:636:26: warning: cast truncates bits from constant value (10000000 becomes 0)
drivers/pnp/pnpacpi/rsparser.c:660:26: warning: cast truncates bits from constant value (10000000 becomes 0)
drivers/pnp/pnpacpi/rsparser.c:682:26: warning: cast truncates bits from constant value (10000000 becomes 0)

these all seem to come from the 'flags' variables you added
as part of patch 29df8d8f being char's and IORESOURCE_DISABLED 
being 0x10000000 so lines like:

+       unsigned char flags = 0;

+               flags |= IORESOURCE_DISABLED;

shouldn't work.

Dave

-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\ gro.gilbert @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

             reply	other threads:[~2011-08-22  0:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-22  0:59 Dr. David Alan Gilbert [this message]
2011-06-09 18:58 ` 'flags' in rsparser.c change from 'register disabled resources' patch Witold Szczeponik
2011-06-09 19:03   ` [PATCH] PNPACPI: Simplify disabled resource registration Witold Szczeponik
2011-09-13 16:25     ` Bjorn Helgaas
2011-09-13 16:25       ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110822005902.GA30602@gallifrey \
    --to=linux@treblig.org \
    --cc=Witold.Szczeponik@gmx.net \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.