Re: [PATCH 01/07] ARM: mach-shmobile: Kota2 SCIFA2 and SMSC911X support

[Paul Mundt <lethal@linux-sh.org>]

On Thu, Aug 18, 2011 at 02:44:07PM +0900, Magnus Damm wrote:
> +static void __init kota2_timer_init(void)
> +{
> +	sh73a0_clock_init();
> +	shmobile_timer.init();
> +	return;
> +}
> +
Pointless return.

> --- 0001/arch/arm/mach-shmobile/platsmp.c
> +++ work/arch/arm/mach-shmobile/platsmp.c	2011-08-18 13:38:02.000000000 +0900
> @@ -21,9 +21,11 @@
>  #include <asm/mach-types.h>
>  #include <mach/common.h>
>  
> +#define is_sh73a0() (machine_is_ag5evm() || machine_is_kota2())
> +
>  static unsigned int __init shmobile_smp_get_core_count(void)
>  {
> -	if (machine_is_ag5evm())
> +	if (is_sh73a0())
>  		return sh73a0_get_core_count();
>  
>  	return 1;

No. If you want to do this then simply do what the other platforms are
doing and construct a cpu.h, then you can centrally define things and use
cpu_is_xxx() outright. Making CPU inferences from mach type is just
asking for trouble.