From: Johan Hedberg <johan.hedberg@gmail.com>
To: Jakub Adamek <adamek.kuba@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH obexd] Fix encoding of empty unicode headers
Date: Mon, 22 Aug 2011 11:15:26 +0300 [thread overview]
Message-ID: <20110822081526.GC11306@dell> (raw)
In-Reply-To: <1313327785-7767-1-git-send-email-adamek.kuba@gmail.com>
Hi Jakub,
On Sun, Aug 14, 2011, Jakub Adamek wrote:
> According to IrOBEX:
> "An empty Name header is defined as a Name header of length 3 (one
> byte opcode + two byte length)."
>
> The current code encodes an empty header with 5 bytes, including two
> bytes of null-terminator.
>
> This patch assumes that this definition of emptyness applies to all
> unicode headers, not just the name header.
> ---
> gobex/gobex-header.c | 11 ++++++++-
> unit/test-gobex-header.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 65 insertions(+), 1 deletions(-)
Applied. Thanks.
Johan
prev parent reply other threads:[~2011-08-22 8:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-14 13:16 [PATCH obexd] Fix encoding of empty unicode headers Jakub Adamek
2011-08-22 8:15 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110822081526.GC11306@dell \
--to=johan.hedberg@gmail.com \
--cc=adamek.kuba@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.