All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Hans J. Koch" <hjk@hansjkoch.de>
To: Wanlong Gao <wanlong.gao@gmail.com>
Cc: linux-kernel@vger.kernel.org, hjk@hansjkoch.de, gregkh@suse.de,
	Wanlong Gao <gaowanlong@cn.fujitsu.com>
Subject: Re: [PATCH v2] drivers:uio:change the goto label to consistent with others
Date: Mon, 22 Aug 2011 13:30:04 +0200	[thread overview]
Message-ID: <20110822113004.GB14373@local> (raw)
In-Reply-To: <1313813528-30913-2-git-send-email-wanlong.gao@gmail.com>

On Sat, Aug 20, 2011 at 12:12:08PM +0800, Wanlong Gao wrote:
> From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> 
> sorry for v1's typo mistake.
> Thanks
> 
> Remove one *goto* label in uio.c.

Nice, that makes it a bit cleaner.

Thanks,
Hans

> 
> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>

Signed-off-by: "Hans J. Koch" <hjk@hansjkoch.de>

> ---
>  drivers/uio/uio.c |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
> index d2efe82..c89f12a 100644
> --- a/drivers/uio/uio.c
> +++ b/drivers/uio/uio.c
> @@ -750,14 +750,13 @@ static int uio_major_init(void)
>  
>  	uio_major = MAJOR(uio_dev);
>  	uio_cdev = cdev;
> -	result = 0;
> -out:
> -	return result;
> +	return 0;
>  out_put:
>  	kobject_put(&cdev->kobj);
>  out_unregister:
>  	unregister_chrdev_region(uio_dev, UIO_MAX_DEVICES);
> -	goto out;
> +out:
> +	return result;
>  }
>  
>  static void uio_major_cleanup(void)
> -- 
> 1.7.4.1
> 
> 

  reply	other threads:[~2011-08-22 11:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-20  4:12 [PATCH] drivers:uio:fix section mismatch in uio_pdrv_genirq.c Wanlong Gao
2011-08-20  4:12 ` [PATCH v2] drivers:uio:change the goto label to consistent with others Wanlong Gao
2011-08-22 11:30   ` Hans J. Koch [this message]
2011-08-22 12:03 ` [PATCH] drivers:uio:fix section mismatch in uio_pdrv_genirq.c Hans J. Koch
2011-08-22 12:50   ` Wanlong Gao
2011-08-22 14:20     ` Hans J. Koch
2011-08-22 14:27       ` Wanlong Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110822113004.GB14373@local \
    --to=hjk@hansjkoch.de \
    --cc=gaowanlong@cn.fujitsu.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wanlong.gao@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.