From: Samuel Ortiz <sameo@linux.intel.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Rajendra Nayak <rnayak@ti.com>,
Balaji T K <balajitk@ti.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>
Subject: Re: [PATCH] mfd: twl6030-irq: Make sure to call request_irq before using the irq_num
Date: Mon, 22 Aug 2011 15:32:54 +0200 [thread overview]
Message-ID: <20110822133254.GP4607@sortiz-mobl> (raw)
In-Reply-To: <1313047260.27089.1.camel@phoenix>
Hi Axel,
On Thu, Aug 11, 2011 at 03:21:00PM +0800, Axel Lin wrote:
> I was trying to fix the error handling part because in the case of
> request_irq failure, it should call kthread_stop instead of free_irq.
> But it seems more reasonable to do request_irq before calling kthread_run.
I don't have the hardware, but that makes sense to me.
Unless some from TI NACK this patch, I'm applying it.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2011-08-22 13:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 7:21 [PATCH] mfd: twl6030-irq: Make sure to call request_irq before using the irq_num Axel Lin
2011-08-22 13:32 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110822133254.GP4607@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=axel.lin@gmail.com \
--cc=balajitk@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rnayak@ti.com \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.