All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Xiaofeng Yan <xiaofeng.yan@windriver.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] qt4-x11-demo-image: Fix bug 999
Date: Mon, 22 Aug 2011 13:52:38 +0100	[thread overview]
Message-ID: <201108221352.38897.paul.eggleton@linux.intel.com> (raw)
In-Reply-To: <1b28a73fd25e40a29659583ee1432f7f3c720b68.1314010928.git.xiaofeng.yan@windriver.com>

On Monday 22 August 2011 12:34:11 Xiaofeng Yan wrote:
> From: Xiaofeng Yan <xiaofeng.yan@windriver.com>
> 
> [YOCTO #999]
> Add qt4-x11-demo-image for fixing bug 999

Thanks for looking into this bug. A couple of comments though:

1) You need to specify an appropriate commit message. This should include a 
reason for adding (i.e. to allow easy testing of Qt4 on X11); you also need to 
credit OE if that's where you copied some of the metadata from.

2) This adds quite a lot more than should be needed for a simple demo image. 
The image itself should inherit from core-image, this will save a lot of 
duplication. Why are you adding palmtop.bbclass, sdk.bbclass, task-sdk-host, 
micro-base-image etc.? These should not be needed at all.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre



  reply	other threads:[~2011-08-22 12:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-22 11:34 [PATCH 0/1] qt4-x11-demo-image: Fix bug 999 Xiaofeng Yan
2011-08-22 11:34 ` [PATCH 1/1] " Xiaofeng Yan
2011-08-22 12:52   ` Paul Eggleton [this message]
2011-08-23  1:26     ` Xiaofeng Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201108221352.38897.paul.eggleton@linux.intel.com \
    --to=paul.eggleton@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=xiaofeng.yan@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.