From: Josh Triplett <josh@joshtriplett.org>
To: Pekka Enberg <penberg@kernel.org>
Cc: linux-sparse@vger.kernel.org, Christopher Li <sparse@chrisli.org>,
Jeff Garzik <jgarzik@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 4/5] sparse, i386: Fix boolean bit size
Date: Mon, 22 Aug 2011 08:28:47 -0700 [thread overview]
Message-ID: <20110822152847.GC21442@leaf> (raw)
In-Reply-To: <1314021451-24808-4-git-send-email-penberg@kernel.org>
On Mon, Aug 22, 2011 at 04:57:30PM +0300, Pekka Enberg wrote:
> The value of 'ctype->bit_size' is set to 1 for booleans which confuses the i386
> backend:
>
> ./compile allocate.c
> compile: compile-i386.c:1406: emit_binop: Assertion `0' failed.
> Aborted
>
> Looking at the code, we assume that "bit_size / 8" gives a sane result on
> various places. This patch fixes the problem by bumping bit_size to 8 for
> booleans. This also makes sizeof(_Bool) return 1 which is consistent with what
> GCC 4.4.3, for example, does.
Seems reasonable; that would make it consistent with the behavior of
structs or arrays of bool, at least in GCC. As far as I know, GCC
doesn't have any logic to attempt to compress a bool down to a single
bit of storage.
- Josh Triplett
next prev parent reply other threads:[~2011-08-22 15:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 13:57 [PATCH 1/5] sparse: Show expected vs. actual output on test failure Pekka Enberg
2011-08-22 13:57 ` [PATCH 2/5] sparse: Enable unhandled validation tests Pekka Enberg
2011-08-22 15:24 ` Josh Triplett
2011-08-24 21:05 ` Christopher Li
2011-08-25 10:30 ` Pekka Enberg
2011-08-26 3:42 ` Christopher Li
2011-08-22 13:57 ` [PATCH 3/5] sparse: Fix __builtin_safe_p for pure and const functions Pekka Enberg
2011-08-22 13:57 ` [PATCH 4/5] sparse, i386: Fix boolean bit size Pekka Enberg
2011-08-22 15:28 ` Josh Triplett [this message]
2011-08-26 3:59 ` Christopher Li
2011-08-26 5:28 ` Pekka Enberg
2011-08-26 6:26 ` Pekka Enberg
2011-08-22 13:57 ` [PATCH 5/5] sparse: Add end-to-end compiler shell script Pekka Enberg
2011-08-22 14:51 ` Jeff Garzik
2011-08-25 10:28 ` Pekka Enberg
2011-08-23 22:32 ` [PATCH 1/5] sparse: Show expected vs. actual output on test failure Christopher Li
2011-08-27 8:20 ` Pekka Enberg
2011-08-26 9:10 ` Pekka Enberg
2011-08-27 1:58 ` Christopher Li
2011-08-27 8:24 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110822152847.GC21442@leaf \
--to=josh@joshtriplett.org \
--cc=jgarzik@redhat.com \
--cc=linux-sparse@vger.kernel.org \
--cc=penberg@kernel.org \
--cc=sparse@chrisli.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.