From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] [v2] sound/soc/fsl/fsl_dma.c: add missing of_node_put Date: Mon, 22 Aug 2011 23:30:31 +0100 Message-ID: <20110822223031.GF30609@opensource.wolfsonmicro.com> References: <1314022961-27513-1-git-send-email-timur@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 66F071039D2 for ; Tue, 23 Aug 2011 00:30:34 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1314022961-27513-1-git-send-email-timur@freescale.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Timur Tabi Cc: alsa-devel@alsa-project.org, tiwai@suse.de, devicetree-discuss@lists.ozlabs.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, grant.likely@secretlab.ca, julia@diku.dk, linuxppc-dev@lists.ozlabs.org, lrg@ti.com List-Id: alsa-devel@alsa-project.org On Mon, Aug 22, 2011 at 09:22:41AM -0500, Timur Tabi wrote: > of_parse_phandle increments the reference count of np, so this should be > decremented before trying the next possibility. > > Since we don't actually use np, we can decrement the reference count > immediately. Applied, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Date: Mon, 22 Aug 2011 22:30:31 +0000 Subject: Re: [PATCH] [v2] sound/soc/fsl/fsl_dma.c: add missing of_node_put Message-Id: <20110822223031.GF30609@opensource.wolfsonmicro.com> List-Id: References: <1314022961-27513-1-git-send-email-timur@freescale.com> In-Reply-To: <1314022961-27513-1-git-send-email-timur@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Timur Tabi Cc: alsa-devel@alsa-project.org, tiwai@suse.de, devicetree-discuss@lists.ozlabs.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, grant.likely@secretlab.ca, julia@diku.dk, linuxppc-dev@lists.ozlabs.org, lrg@ti.com On Mon, Aug 22, 2011 at 09:22:41AM -0500, Timur Tabi wrote: > of_parse_phandle increments the reference count of np, so this should be > decremented before trying the next possibility. > > Since we don't actually use np, we can decrement the reference count > immediately. Applied, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 7DEABB6F7F for ; Tue, 23 Aug 2011 08:37:12 +1000 (EST) Date: Mon, 22 Aug 2011 23:30:31 +0100 From: Mark Brown To: Timur Tabi Subject: Re: [PATCH] [v2] sound/soc/fsl/fsl_dma.c: add missing of_node_put Message-ID: <20110822223031.GF30609@opensource.wolfsonmicro.com> References: <1314022961-27513-1-git-send-email-timur@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1314022961-27513-1-git-send-email-timur@freescale.com> Cc: alsa-devel@alsa-project.org, tiwai@suse.de, devicetree-discuss@lists.ozlabs.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, perex@perex.cz, julia@diku.dk, linuxppc-dev@lists.ozlabs.org, lrg@ti.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Aug 22, 2011 at 09:22:41AM -0500, Timur Tabi wrote: > of_parse_phandle increments the reference count of np, so this should be > decremented before trying the next possibility. > > Since we don't actually use np, we can decrement the reference count > immediately. Applied, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754233Ab1HVWah (ORCPT ); Mon, 22 Aug 2011 18:30:37 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:43374 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753980Ab1HVWaf (ORCPT ); Mon, 22 Aug 2011 18:30:35 -0400 Date: Mon, 22 Aug 2011 23:30:31 +0100 From: Mark Brown To: Timur Tabi Cc: kernel-janitors@vger.kernel.org, lrg@ti.com, perex@perex.cz, tiwai@suse.de, grant.likely@secretlab.ca, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, julia@diku.dk Subject: Re: [PATCH] [v2] sound/soc/fsl/fsl_dma.c: add missing of_node_put Message-ID: <20110822223031.GF30609@opensource.wolfsonmicro.com> References: <1314022961-27513-1-git-send-email-timur@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1314022961-27513-1-git-send-email-timur@freescale.com> X-Cookie: You will be run over by a beer truck. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 22, 2011 at 09:22:41AM -0500, Timur Tabi wrote: > of_parse_phandle increments the reference count of np, so this should be > decremented before trying the next possibility. > > Since we don't actually use np, we can decrement the reference count > immediately. Applied, thanks.