All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Péter Ujfalusi" <peter.ujfalusi@ti.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"Girdwood, Liam" <lrg@ti.com>,
	"Lopez Cruz, Misael" <misael.lopez@ti.com>
Subject: Re: [PATCH v2 1/2] ASoC: DAPM: Add private data pointer for DAPM widget
Date: Mon, 22 Aug 2011 23:32:32 +0100	[thread overview]
Message-ID: <20110822223232.GB29473@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1508700.DYiRuuCFX2@barack>

On Mon, Aug 22, 2011 at 04:33:20PM +0300, Péter Ujfalusi wrote:
> On Saturday 20 August 2011 09:02:20 Mark Brown wrote:

> > If we're adding this we should probably go the accessor route like we do
> > with the driver data for the CODECs.

> Something like:

> static inline void *snd_soc_widget_get_pdata(struct snd_soc_dapm_widget *w)
> {
>         return w->private_data;
> }

Yeah, something like that.

> Another option at the moment is that I create global variable within the omap-
> mcpdm.c, so I can have access to the mcpdm within the dapm event handler.

That'll probably break in future I'd guess.

  reply	other threads:[~2011-08-22 22:32 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-19  7:41 [PATCH v2 0/2] ASoC: omap-mcpdm: New McPDM driver Peter Ujfalusi
2011-08-19  7:41 ` [PATCH v2 1/2] ASoC: DAPM: Add private data pointer for DAPM widget Peter Ujfalusi
2011-08-20  7:02   ` Mark Brown
2011-08-22 13:33     ` Péter Ujfalusi
2011-08-22 22:32       ` Mark Brown [this message]
2011-08-19  7:41 ` [PATCH v2 2/2] ASoC: omap-mcpdm: Replace legacy driver Peter Ujfalusi
2011-08-19  8:38   ` Lars-Peter Clausen
2011-08-19  8:49     ` Lars-Peter Clausen
2011-08-19 12:38       ` Liam Girdwood
2011-08-19 13:13         ` Lars-Peter Clausen
2011-08-19 16:59           ` Liam Girdwood
2011-08-22 11:34       ` Péter Ujfalusi
2011-08-22 13:04         ` Mark Brown
2011-08-22 13:39         ` Lars-Peter Clausen
2011-08-23  6:49           ` Péter Ujfalusi
2011-08-23 10:14             ` Lars-Peter Clausen
2011-08-26  8:08               ` Péter Ujfalusi
2011-08-19 13:33   ` Paul Menzel
2011-08-20  7:01   ` Mark Brown
2011-08-23  7:52     ` Péter Ujfalusi
2011-08-23 10:57       ` Mark Brown
2011-08-26  8:01       ` Péter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110822223232.GB29473@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=lrg@ti.com \
    --cc=misael.lopez@ti.com \
    --cc=peter.ujfalusi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.