From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: (i5k_amb) Replace BUG with WARN
Date: Tue, 23 Aug 2011 04:01:07 +0000 [thread overview]
Message-ID: <20110823040107.GA26417@ericsson.com> (raw)
In-Reply-To: <1313689771-31221-1-git-send-email-guenter.roeck@ericsson.com>
On Fri, Aug 19, 2011 at 07:05:50PM -0400, Guenter Roeck wrote:
> Hi Jean,
>
> On Fri, Aug 19, 2011 at 05:16:24PM -0400, Jean Delvare wrote:
> > Hi Guenter,
> >
> > On Thu, 18 Aug 2011 10:49:31 -0700, Guenter Roeck wrote:
> > > Executing BUG as a result of an internal driver error seems to be a bit harsh.
> >
> > Well, that's pretty much what BUG was designed for: internal errors
> > that aren't supposed to happen.
> >
> Problem with BUG is that it can be undefined for some configurations,
> in which case it doesn't do anything.
>
> Also, while it may make sense to bring down the system if there is a severe bug
> which makes it impossible to continue, that seems to be a bit excessive
> for a hwmon driver.
>
> > > Replace it with WARN and return -ENODEV if the condition is seen.
> >
> > I'm not sure what is the benefit of WARN over pr_warn() in this case.
> >
> WARN generates a traceback, pr_warn doesn't. I think the scope is a bit different
> - one warns about a programming error, the other warns about a system consition.
>
Hi all,
As I don't see a consensus for my proposed patch, I'll drop it.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2011-08-23 4:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-18 17:49 [lm-sensors] [PATCH] hwmon: (i5k_amb) Replace BUG with WARN Guenter Roeck
2011-08-18 18:30 ` Darrick J. Wong
2011-08-19 21:16 ` Jean Delvare
2011-08-19 23:05 ` Guenter Roeck
2011-08-23 4:01 ` Guenter Roeck [this message]
2011-08-23 16:55 ` Darrick J. Wong
2011-08-23 17:14 ` Guenter Roeck
2011-08-23 18:05 ` Jean Delvare
2011-08-23 22:28 ` Darrick J. Wong
2011-08-24 4:06 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110823040107.GA26417@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.