From: jamie@jamieiles.com (Jamie Iles)
To: linux-arm-kernel@lists.infradead.org
Subject: v6 software reset fails on 1176
Date: Tue, 23 Aug 2011 17:32:47 +0100 [thread overview]
Message-ID: <20110823163247.GM2796@pulham.picochip.com> (raw)
Hi Will,
I'm trying to use the cpu_v6_reset that you added in "ARM: proc: add
definition of cpu_reset for ARMv6 and ARMv7 cores", but I've found that
on my 1176 platform, it never gets to the branch to the reset vector.
Removing the ISB allows the branch instruction to be in the pipeline by
the time the MMU is disabled, but I'm not sure if this is the correct
fix. Having said that, I don't see how this can work with an ISB in
there.
Jamie
diff --git a/arch/arm/mm/proc-v6.S b/arch/arm/mm/proc-v6.S
index 219138d..3b6737a 100644
--- a/arch/arm/mm/proc-v6.S
+++ b/arch/arm/mm/proc-v6.S
@@ -59,8 +59,6 @@ ENTRY(cpu_v6_reset)
mrc p15, 0, r1, c1, c0, 0 @ ctrl register
bic r1, r1, #0x1 @ ...............m
mcr p15, 0, r1, c1, c0, 0 @ disable MMU
- mov r1, #0
- mcr p15, 0, r1, c7, c5, 4 @ ISB
mov pc, r0
/*
next reply other threads:[~2011-08-23 16:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 16:32 Jamie Iles [this message]
2011-08-23 17:09 ` v6 software reset fails on 1176 Will Deacon
2011-08-23 17:34 ` Jamie Iles
2011-08-23 17:47 ` Will Deacon
2011-08-23 17:56 ` Jamie Iles
2011-08-23 18:00 ` Will Deacon
2011-08-24 12:27 ` Jamie Iles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110823163247.GM2796@pulham.picochip.com \
--to=jamie@jamieiles.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.