From: Johan Hedberg <johan.hedberg@gmail.com>
To: David Stockwell <dstockwell@frequency-one.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/3] AVRCP: Metadata item #7 should return TrackDuration
Date: Wed, 24 Aug 2011 11:30:23 +0300 [thread overview]
Message-ID: <20110824083023.GA19274@dell> (raw)
In-Reply-To: <201108232225.08328.dstockwell@frequency-one.com>
Hi David,
On Tue, Aug 23, 2011, David Stockwell wrote:
> @@ -194,7 +194,8 @@ enum media_info_id {
> MEDIA_INFO_TRACK = 4,
> MEDIA_INFO_N_TRACKS = 5,
> MEDIA_INFO_GENRE = 6,
> - MEDIA_INFO_CURRENT_POSITION = 7,
> + MEDIA_INFO_PLAYING_TIME = 7,
> + MEDIA_INFO_LAST = MEDIA_INFO_PLAYING_TIME,
> };
Actually that's not quite what I meant. The idea was this:
MEDIA_INFO_PLAYING_TIME = 7,
MEDIA_INFO_LAST,
That way you can just keep adding new entries above MEDIA_INFO_LAST and
its value will always be the last "real" value + 1 (which also means
that the comparison in the for-loop changes from <= to <).
Johan
next prev parent reply other threads:[~2011-08-24 8:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 3:25 [PATCH 2/3] AVRCP: Metadata item #7 should return TrackDuration David Stockwell
2011-08-24 8:30 ` Johan Hedberg [this message]
2011-08-24 12:39 ` David Stockwell
-- strict thread matches above, loose matches on Subject: below --
2011-08-24 13:05 David Stockwell
2011-08-24 15:02 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110824083023.GA19274@dell \
--to=johan.hedberg@gmail.com \
--cc=dstockwell@frequency-one.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.