From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [RFC PATCH] slimbus: Linux driver framework for SLIMbus. Date: Wed, 24 Aug 2011 16:14:58 +0200 Message-ID: <201108241614.58800.arnd@arndb.de> References: <1313019091-15354-1-git-send-email-kheitke@codeaurora.org> <1314144826.1659.30.camel@Joe-Laptop> Mime-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from moutng.kundenserver.de ([212.227.17.8]:53565 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751365Ab1HXOPP (ORCPT ); Wed, 24 Aug 2011 10:15:15 -0400 In-Reply-To: <1314144826.1659.30.camel@Joe-Laptop> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Joe Perches Cc: Kenneth Heitke , davidb@codeaurora.org, bryanh@codeaurora.org, linux-arm-msm@vger.kernel.org, Sagar Dharia , rdunlap@xenotime.net, rmk+kernel@arm.linux.org.uk, john.stultz@linaro.org, akpm@linux-foundation.org, ohad@wizery.com, gregkh@suse.de, Stefan Richter On Wednesday 24 August 2011, Joe Perches wrote: > It might be reasonable to have slim specific macros/functions > for message logging. That might allow slim specific prefixes. > > For functions, you could look at netdev_: > > slim_(struct slim_controller *ctrl, const char *fmt, ...) > > or macros like: > > #define slim_printk(level, ctrl, fmt, ...) \ > dev_printk(level, &(ctrl)->dev, fmt, ##__VA_ARGS__) > #define slim_(level, ctrl, fmt, ...) \ > slim_printk(KERN_, ctrl, fmt, ##__VA_ARGS__) > etc. Hi Joe, My recommendation is always against such macros, and for using the dev_* and pr_* macros directly. The reason is mostly so that a causal reader with a kernel background can immediately understand what they do, rather than having to look up extra macro definition, e.g. to see if they add the newline character or not. I agree with all your other comments though, thanks for taking a look as well. Arnd