From: Greg KH <greg@kroah.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
edwin_rong <edwin_rong@realsil.com.cn>
Subject: Re: linux-next: build failure after merge of the final tree (staging tree related)
Date: Wed, 24 Aug 2011 15:57:58 -0700 [thread overview]
Message-ID: <20110824225758.GA3454@kroah.com> (raw)
In-Reply-To: <20110825085420.521cc24fddadc7753dc67199@canb.auug.org.au>
On Thu, Aug 25, 2011 at 08:54:20AM +1000, Stephen Rothwell wrote:
> Hi Greg,
>
> On Wed, 24 Aug 2011 14:16:46 -0700 Greg KH <greg@kroah.com> wrote:
> >
> > To fix it, all we have to do is include linux/vmalloc.h, right? Or is
>
> I would assume so.
>
> > ppc "special" in some other way regarding this call?
>
> I assume it happens just because vmalloc.h is implicitly included by some
> other header file on x86 and not on ppc.
>
> This is why we have "Rule 1" in Documentation/SubmitChecklist. Relying
> on the implicit inclusion of header files is bound to trip us up on some
> architecture or platform or combination of CONFIG options.
Fair enough, I've made this fix in my tree, so it should be good now.
thanks,
greg k-h
next prev parent reply other threads:[~2011-08-24 22:58 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 5:47 linux-next: build failure after merge of the final tree (staging tree related) Stephen Rothwell
2011-08-24 21:16 ` Greg KH
2011-08-24 22:54 ` Stephen Rothwell
2011-08-24 22:57 ` Greg KH [this message]
2011-08-24 23:28 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2014-02-10 4:54 Stephen Rothwell
2014-02-10 5:04 ` Greg KH
2013-06-19 8:10 Stephen Rothwell
2013-06-19 9:26 ` Peng Tao
2013-06-19 14:37 ` Greg KH
2013-06-20 10:52 ` Peng Tao
2013-06-24 22:40 ` Greg KH
2013-06-24 23:40 ` Stephen Rothwell
2013-06-24 23:50 ` Greg KH
2013-06-25 0:22 ` Peng Tao
2013-06-25 2:13 ` Greg KH
2013-04-24 7:56 linux-next: build failure after merge of the final tree (staging tree related)) Stephen Rothwell
2013-04-24 17:53 ` H Hartley Sweeten
2013-04-24 18:33 ` H Hartley Sweeten
2013-03-13 5:39 linux-next: build failure after merge of the final tree (staging tree related) Stephen Rothwell
2013-03-14 20:23 ` Paul Zimmerman
2013-03-14 20:33 ` Greg KH
2013-03-06 0:35 Stephen Rothwell
2013-03-06 0:43 ` Greg KH
2013-03-06 13:56 ` Konrad Rzeszutek Wilk
2013-03-06 20:04 ` Konrad Rzeszutek Wilk
2013-03-06 20:46 ` Stephen Rothwell
2013-03-06 20:50 ` Stephen Rothwell
2013-03-06 22:23 ` Konrad Rzeszutek Wilk
2013-03-06 22:11 ` Greg KH
2013-03-06 22:21 ` Konrad Rzeszutek Wilk
2012-11-13 5:51 Stephen Rothwell
2012-11-13 9:24 ` Jonathan Cameron
2012-11-13 18:48 ` Greg KH
2012-09-24 14:29 Stephen Rothwell
2012-09-10 7:04 Stephen Rothwell
2012-09-10 17:31 ` Greg KH
2012-09-05 5:48 Stephen Rothwell
2012-09-06 18:06 ` Geert Uytterhoeven
2012-05-16 10:06 Stephen Rothwell
2012-05-16 12:49 ` Greg KH
2012-05-16 14:17 ` Dan Magenheimer
2012-05-16 15:10 ` Greg KH
2012-02-27 7:13 Stephen Rothwell
2012-02-27 21:16 ` Greg KH
2012-02-29 7:35 ` Chris Kelly
2012-02-29 7:52 ` Stephen Rothwell
2012-02-29 17:08 ` Chris Kelly
2012-02-13 6:19 Stephen Rothwell
2012-02-13 6:45 ` Greg KH
2012-02-13 14:13 ` Seth Jennings
2012-02-13 14:48 ` Seth Jennings
2012-02-13 15:03 ` Greg KH
2011-10-04 8:05 Stephen Rothwell
2011-10-04 8:49 ` Jonathan Cameron
2011-08-25 6:17 Stephen Rothwell
2011-07-18 9:36 Stephen Rothwell
2011-07-19 1:01 ` Greg KH
2011-07-28 3:35 ` Stephen Rothwell
2011-08-02 23:17 ` Greg KH
2011-07-07 6:25 Stephen Rothwell
2011-07-07 13:44 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110824225758.GA3454@kroah.com \
--to=greg@kroah.com \
--cc=edwin_rong@realsil.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.