All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] beagleboard: enable HUB power on all variants of the BeagleBoard
Date: Thu, 25 Aug 2011 05:22:09 +0200	[thread overview]
Message-ID: <201108250522.09262.marek.vasut@gmail.com> (raw)
In-Reply-To: <1314226061-6933-1-git-send-email-agnel.joel@gmail.com>

On Thursday, August 25, 2011 12:47:41 AM Joel A Fernandes wrote:
> From: Christian Spielberger <c.spielberger@bct-electronic.com>
> 
> Signed-off-by: Joel A Fernandes <joelagnel@ti.com>
> Cc: "Eric B??nard" <eric@eukrea.com>
> Cc: "Christian Spielberger" <c.spielberger@bct-electronic.com>
> ---
> Pushing this patch myself as no one else did.
> 
> Previous discussions:
> http://article.gmane.org/gmane.comp.boot-loaders.u-boot/105663/
> http://article.gmane.org/gmane.comp.boot-loaders.u-boot/101540/
> 
>  board/ti/beagle/beagle.c |   10 +++++++++-
>  1 files changed, 9 insertions(+), 1 deletions(-)
> 
> diff --git a/board/ti/beagle/beagle.c b/board/ti/beagle/beagle.c
> index 13fe39b..9d65e9e 100644
> --- a/board/ti/beagle/beagle.c
> +++ b/board/ti/beagle/beagle.c
> @@ -332,7 +332,15 @@ int misc_init_r(void)
>  		setenv(expansion_config.env_var, expansion_config.env_setting);
> 
>  	twl4030_power_init();
> -	twl4030_led_init(TWL4030_LED_LEDEN_LEDAON | TWL4030_LED_LEDEN_LEDBON);
> +	switch (get_board_revision()) {
> +	case REVISION_XM_C:
> +	case REVISION_C4:
> +		twl4030_led_init(TWL4030_LED_LEDEN_LEDAON | TWL4030_LED_LEDEN_LEDBON);
> +		break;
> +	default:
> +		twl4030_led_init(TWL4030_LED_LEDEN_LEDBON);
> +		break;
> +	}

Am I just too sleepy or the Subject doesn't correlate with what the patch does 
...

My understanding of Subject is that it enables power on HUB ... USB HUB ? But 
the patch enables some LEDs ?

I might be wrong.

CHeers
> 
>  	/* Set GPIO states before they are made outputs */
>  	writel(GPIO23 | GPIO10 | GPIO8 | GPIO2 | GPIO1,

  reply	other threads:[~2011-08-25  3:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-24 22:47 [U-Boot] [PATCH] beagleboard: enable HUB power on all variants of the BeagleBoard Joel A Fernandes
2011-08-25  3:22 ` Marek Vasut [this message]
2011-08-25  3:30   ` Jason Kridner
2011-08-25  3:38     ` Marek Vasut
     [not found]   ` <09c7a42739ab4b60940f47b442600eab@DLEE74.ent.ti.com>
2011-08-26 18:44     ` Joel A Fernandes
     [not found] ` <9c84f85dcba04a05bf02cd937fa69bf3@DFLE70.ent.ti.com>
     [not found]   ` <CAD=GYpbtJ9Hmjy-XdAHK6XmZTbj3PWnes9ZZpOROuiuKPyiFaA@mail.gmail.com>
2011-08-27  4:46     ` Joel A Fernandes
2011-08-27 13:51       ` Eric Bénard
2011-08-27 16:19         ` Jason Kridner
2011-08-27 19:16           ` Joel A Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201108250522.09262.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.