From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH] xenstored: allow guests to shutdown all of its watches using XS_RESET Date: Thu, 25 Aug 2011 17:19:18 +0200 Message-ID: <20110825151918.GA25643@aepfle.de> References: <31687c9a9e3edfae7cf2.1313130830@probook.site> <20054.26108.76939.531036@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20054.26108.76939.531036@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Thu, Aug 25, Ian Jackson wrote: > Olaf Hering writes ("[Xen-devel] [PATCH] xenstored: allow guests to shutdown all of its watches using XS_RESET"): > > Add a new XS_RESET command to do the reset on behalf of the guest. > > I'm afraid I still think this is wrong. There is a later patch XS_RESET_WATCHES. http://lists.xensource.com/archives/html/xen-devel/2011-08/msg00529.html > * The XS_RESET command as you have it takes too many arguments. It > should probably not take any arguments at all. The later patch does not take arguments. > * You have failed to update the specification document which describes > the xenstored protocol (in docs/misc/) The later patch adds the XS_RESET_WATCHES part to the xenstored.txt. > * Your XS_RESET command doesn't just delete watches and transactions. > It also: > - discards outstanding responses to earlier commands > - discards potential incoming partial commands > - resets the ring pointers > I don't think any of these things are necessary. If they are, > please explain. I think you should have your do_reset simply call > conn_delete_all_watches and conn_delete_all_transactions. Thats what the later patch does. Olaf