From: Dan Williams <dan.j.williams@intel.com>
To: neilb@suse.de
Cc: linux-raid@vger.kernel.org, marcin.labun@intel.com,
ed.ciechanowski@intel.com
Subject: [PATCH 8/9] util: allow regular files through test_partition()
Date: Thu, 25 Aug 2011 19:14:40 -0700 [thread overview]
Message-ID: <20110826021440.28015.6602.stgit@localhost6.localdomain6> (raw)
In-Reply-To: <20110826020908.28015.52384.stgit@localhost6.localdomain6>
When using the --dump capability the resulting files cannot be read
unless test_partition allows regular files.
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
util.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/util.c b/util.c
index ce03239..5d573bc 100644
--- a/util.c
+++ b/util.c
@@ -279,6 +279,12 @@ int test_partition(int fd)
*/
struct blkpg_ioctl_arg a;
struct blkpg_partition p;
+ struct stat st;
+
+ /* ignore regular files */
+ if (fstat(fd, &st) != -1 && S_ISREG(st.st_mode))
+ return 0;
+
a.op = BLKPG_DEL_PARTITION;
a.data = (void*)&p;
a.datalen = sizeof(p);
next prev parent reply other threads:[~2011-08-26 2:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 2:13 [PATCH 0/9] recovering an imsm raid5 array Dan Williams
2011-08-26 2:14 ` [PATCH 1/9] imsm: fix max disks per array Dan Williams
2011-08-26 2:14 ` [PATCH 2/9] imsm: fix, stop metadata updates to newly failed devices Dan Williams
2011-08-26 2:14 ` [PATCH 3/9] imsm: fix display spares Dan Williams
2011-08-26 2:14 ` [PATCH 4/9] sysfs: fix sysfs_disk_to_scsi_id Dan Williams
2011-08-26 2:14 ` [PATCH 5/9] imsm: fix reserved sectors for spares Dan Williams
2011-08-26 19:51 ` Williams, Dan J
2011-08-30 2:20 ` NeilBrown
2011-09-06 20:42 ` Williams, Dan J
2011-09-19 12:57 ` Czarnowska, Anna
2011-09-21 4:45 ` NeilBrown
2011-08-26 2:14 ` [PATCH 6/9] mdmon: fix, close spare activation race Dan Williams
2011-08-26 2:14 ` [PATCH 7/9] imsm: support 'missing' devices at Create Dan Williams
2011-08-30 2:26 ` NeilBrown
2011-08-26 2:14 ` Dan Williams [this message]
2011-08-26 2:14 ` [PATCH 9/9] mdadm: 'dump' support Dan Williams
2011-08-30 2:58 ` NeilBrown
2011-08-30 10:12 ` Alexander Kühn
2013-05-16 5:11 ` NeilBrown
2011-08-26 11:06 ` [PATCH 0/9] recovering an imsm raid5 array linbloke
2011-08-30 3:13 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110826021440.28015.6602.stgit@localhost6.localdomain6 \
--to=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=marcin.labun@intel.com \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.