From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Sat, 27 Aug 2011 15:41:55 +0200 Subject: [U-Boot] [PATCH] powerpc/85xx: Add workaround for erratum CPU-A011 on e500mc cores In-Reply-To: <8D21ECF0-CB7E-4DDE-9F18-E1828FF5E8C2@kernel.crashing.org> References: <1314443032-2811-1-git-send-email-galak@kernel.crashing.org> <20110827113627.8167611F9E69@gemini.denx.de> <8D21ECF0-CB7E-4DDE-9F18-E1828FF5E8C2@kernel.crashing.org> Message-ID: <20110827134155.4D30211F9E69@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Kumar Gala, In message <8D21ECF0-CB7E-4DDE-9F18-E1828FF5E8C2@kernel.crashing.org> you wrote: > > Any suggestions on how to do this? - comment it out? > > /* #define CONFIG_SYS_FSL_ERRATUM_CPU_E500MC_A011 */ That would be dead code. You don't want to add all possible #defines to your config files, do you? This is not a good weay to document your code. Apropos documentation - I did not see that you explain CONFIG_SYS_FSL_ERRATUM_CPU_E500MC_A011 (or any other of the ton of CONFIG_SYS_FSL_ERRATUM_* you have) in the readme, or elsewehere. _This_ is what you should fix. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The universe, they said, depended for its operation on the balance of four forces which they identified as charm, persuasion, uncertainty and bloody-mindedness. -- Terry Pratchett, "The Light Fantastic"