From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39189) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qxasx-00017w-Bn for qemu-devel@nongnu.org; Sun, 28 Aug 2011 04:38:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qxasw-0008TC-8g for qemu-devel@nongnu.org; Sun, 28 Aug 2011 04:38:31 -0400 Received: from mail-fx0-f45.google.com ([209.85.161.45]:44735) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qxasw-0008T6-4E for qemu-devel@nongnu.org; Sun, 28 Aug 2011 04:38:30 -0400 Received: by fxbb27 with SMTP id b27so4038597fxb.4 for ; Sun, 28 Aug 2011 01:38:28 -0700 (PDT) Date: Sun, 28 Aug 2011 10:38:24 +0200 From: "Edgar E. Iglesias" Message-ID: <20110828083824.GC11446@zapo> References: <1314302711-20498-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1314302711-20498-1-git-send-email-peter.maydell@linaro.org> Subject: Re: [Qemu-devel] [PATCH 00/17] onenand, omap_gpmc fixes, features List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, patches@linaro.org On Thu, Aug 25, 2011 at 09:04:54PM +0100, Peter Maydell wrote: > This patchset is primarily features and bugfixes for the > omap_gpmc device from the Meego tree. > > We start by adding a new sysbus function to get the MemoryRegion* > for a sysbus MMIO region. This was discussed in > http://www.mail-archive.com/kvm@vger.kernel.org/msg59535.html > and as noted there can also be used to clean up other things, > so it's not just an omap_gpmc thing. > > The bulk of the onenand qdevification patch was in an earlier series > I posted; this update makes it work with MemoryRegions. > > The patches from "omap_gpmc: Take omap_mpu_state* in omap_gpmc_init" > onwards are omap3 preparation; the features they add aren't used in > the omap2 models currently in master. However I'd rather get things > reviewed in more manageable chunks than save them all up for when I > have omap3.c ready for commit... This looks good to me except for some minor questions on: [PATCH 02/17] hw/onenand: Qdevify Cheers