All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	Paul Menage <paul@paulmenage.org>,
	containers@lists.linux-foundation.org,
	linux-pm@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH pm-freezer 3/4] freezer: check freezing() before leaving FROZEN state
Date: Mon, 29 Aug 2011 19:21:32 +0200	[thread overview]
Message-ID: <20110829172132.GA12191@redhat.com> (raw)
In-Reply-To: <20110829171228.GA11339@redhat.com>

On 08/29, Oleg Nesterov wrote:
>
> Hmm. But I got lost a bit. Why do we need freezer_lock to set/clear
> PF_FROZEN ? OK, the code below takes freezer_lock for freezing().
> Is there any other reason?

Ah, at least we need it to serialize with __thaw_task() which does
"if (frozen) wake_up()".

Oleg.


  parent reply	other threads:[~2011-08-29 17:25 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-29 14:04 [PATCH pm-freezer 1/4] cgroup_freezer: fix freezer->state setting bug in freezer_change_state() Tejun Heo
2011-08-29 14:05 ` [PATCH pm-freezer 2/4] freezer: set PF_NOFREEZE on a dying task right before TASK_DEAD Tejun Heo
2011-08-29 14:05   ` [PATCH pm-freezer 3/4] freezer: check freezing() before leaving FROZEN state Tejun Heo
2011-08-29 14:06     ` [PATCH pm-freezer 4/4] freezer: use lock_task_sighand() in fake_signal_wake_up() Tejun Heo
     [not found]       ` <20110829140621.GE18871-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2011-08-29 16:36         ` Oleg Nesterov
2011-08-29 16:36       ` Oleg Nesterov
2011-08-29 16:36       ` Oleg Nesterov
2011-08-29 14:06     ` Tejun Heo
2011-08-29 16:35     ` [PATCH pm-freezer 3/4] freezer: check freezing() before leaving FROZEN state Oleg Nesterov
2011-08-29 17:12       ` Oleg Nesterov
2011-08-29 17:12       ` Oleg Nesterov
2011-08-29 17:21         ` Oleg Nesterov
2011-08-29 17:21         ` Oleg Nesterov [this message]
     [not found]         ` <20110829171228.GA11339-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-08-29 17:21           ` Oleg Nesterov
     [not found]       ` <20110829163533.GB9973-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-08-29 17:12         ` Oleg Nesterov
2011-08-29 16:35     ` Oleg Nesterov
     [not found]     ` <20110829140549.GD18871-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2011-08-29 14:06       ` [PATCH pm-freezer 4/4] freezer: use lock_task_sighand() in fake_signal_wake_up() Tejun Heo
2011-08-29 16:35       ` [PATCH pm-freezer 3/4] freezer: check freezing() before leaving FROZEN state Oleg Nesterov
2011-08-29 14:05   ` Tejun Heo
2011-08-29 18:02   ` [PATCH pm-freezer 2/4] freezer: set PF_NOFREEZE on a dying task right before TASK_DEAD Oleg Nesterov
2011-08-29 18:02   ` Oleg Nesterov
     [not found]   ` <20110829140509.GC18871-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2011-08-29 14:05     ` [PATCH pm-freezer 3/4] freezer: check freezing() before leaving FROZEN state Tejun Heo
2011-08-29 18:02     ` [PATCH pm-freezer 2/4] freezer: set PF_NOFREEZE on a dying task right before TASK_DEAD Oleg Nesterov
2011-08-29 14:05 ` Tejun Heo
     [not found] ` <20110829140418.GB18871-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2011-08-29 14:05   ` Tejun Heo
2011-08-29 16:00   ` [PATCH pm-freezer 1/4] cgroup_freezer: fix freezer->state setting bug in freezer_change_state() Oleg Nesterov
2011-08-29 16:00 ` Oleg Nesterov
2011-08-29 16:00 ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110829172132.GA12191@redhat.com \
    --to=oleg@redhat.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=paul@paulmenage.org \
    --cc=rjw@sisk.pl \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.