From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleg Nesterov Subject: Re: linux-next: build warning after merge of the ptrace tree Date: Mon, 29 Aug 2011 20:20:18 +0200 Message-ID: <20110829182018.GA14729@redhat.com> References: <20110829152704.e533760bfb83fc7480333b20@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20110829152704.e533760bfb83fc7480333b20@canb.auug.org.au> Sender: linux-kernel-owner@vger.kernel.org To: Stephen Rothwell Cc: Tejun Heo , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Matt Fleming List-Id: linux-next.vger.kernel.org Hi Stephen, On 08/29, Stephen Rothwell wrote: > > After merging the ptrace tree, today's linux-next build (powerpc > ppc64_defconfig) produced this warning: > > fs/autofs4/waitq.c: In function 'autofs4_wait': > fs/autofs4/waitq.c:462:17: warning: unused variable 'irqflags' > > Introduced by commit 33ee1d9bc213 ("autofs4: Use set_current_blocked()"). Argh. Thanks again. I've committed the trivial fix. Oleg. commit 2efd0a8f5a5e981022faaec780ee00c05eeee8aa Author: Oleg Nesterov Date: Mon Aug 29 20:17:24 2011 +0200 autofs4_wait: remove the unused irqflags variable irqflags is not used since 33ee1d9bc213, remove it. Reported-by: Stephen Rothwell Signed-off-by: Oleg Nesterov diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c index 58ba49a..09fb503 100644 --- a/fs/autofs4/waitq.c +++ b/fs/autofs4/waitq.c @@ -459,7 +459,6 @@ int autofs4_wait(struct autofs_sb_info *sbi, struct dentry *dentry, if (wq->name.name) { /* Block all but "shutdown" signals while waiting */ sigset_t oldset, blocked; - unsigned long irqflags; oldset = current->blocked; siginitsetinv(&blocked, SHUTDOWN_SIGS & ~oldset.sig[0]);