From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:41894)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1QyCIw-0003lr-SS
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 20:35:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1QyCIv-000536-Vi
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 20:35:50 -0400
Received: from mail-qy0-f173.google.com ([209.85.216.173]:37427)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1QyCIv-00052y-TT
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 20:35:49 -0400
Received: by qyk31 with SMTP id 31so2360621qyk.4
	for <qemu-devel@nongnu.org>; Mon, 29 Aug 2011 17:35:48 -0700 (PDT)
Date: Mon, 29 Aug 2011 20:35:45 -0400
From: Kevin O'Connor <kevin@koconnor.net>
Message-ID: <20110830003545.GA17142@morn.localdomain>
References: <4E5BB532.4010106@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E5BB532.4010106@siemens.com>
Subject: Re: [Qemu-devel] [PATCH] Probe HPET existence
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Andrew Theurer <habanero@linux.vnet.ibm.com>, Gleb Natapov <gleb@redhat.com>, seabios <seabios@seabios.org>, ya su <suya94335@gmail.com>, Alexander Graf <agraf@suse.de>, qemu-devel <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>

On Mon, Aug 29, 2011 at 05:50:10PM +0200, Jan Kiszka wrote:
> QEMU does not provide a HPET block if it was configured with -no-hpet,
> other machines SeaBIOS runs on may lack a HPET as well. Perform basic
> checks the ID register for a reasonable vendor ID and a clock period
> within the valid range, do not build the HPET table if that fails.

It looks okay to me.

BTW, any particular reason to use 0x05F5E100 instead of 100000000?

-Kevin