All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH RFC] hwmon: (max16065) Add chip access
Date: Tue, 30 Aug 2011 14:26:44 +0000	[thread overview]
Message-ID: <20110830142644.GA24125@ericsson.com> (raw)
In-Reply-To: <1314683876-16557-1-git-send-email-guenter.roeck@ericsson.com>

On Tue, Aug 30, 2011 at 03:14:12AM -0400, Jean Delvare wrote:
> On Mon, 29 Aug 2011 22:57:56 -0700, Guenter Roeck wrote:
> > The chips supported by the max16065 driver should not be accessed using direct
> > i2ctools commands. Add warning to driver documentation to alert users.
> > 
> > Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> > ---
> > RFC: Do we want this kind of warning in driver documentation ?
> 
> Sure, this can't hurt. Maybe we could add a section in i2c-tools'
> documentation as well, listing the dangerous chips, starting with this
> one? i2cdetect already has a note about the AT24RF08 for historical
> reasons, I wouldn't mind documenting the "dangerous" chips more
> prominently. Hopefully the list will stay short.
> 
Hopefully yes. Many of the PMBus chips are potentially affected, though.
They typically have a means to protect settings from overwrite, but if that
is not enabled, one can be in hot water. Worst I have seen so far was
to execute i2cdump on an eval board and it lost its configuration :(.

[ ... ]

> 
> Acked-by: Jean Delvare <khali@linux-fr.org>
> 
Thanks for the review!

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2011-08-30 14:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-30  5:57 [lm-sensors] [PATCH RFC] hwmon: (max16065) Add chip access warning Guenter Roeck
2011-08-30  7:14 ` [lm-sensors] [PATCH RFC] hwmon: (max16065) Add chip access Jean Delvare
2011-08-30 14:26 ` Guenter Roeck [this message]
2011-08-30 15:26 ` Jean Delvare
2011-08-30 16:13 ` Guenter Roeck
2011-08-31  7:45 ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110830142644.GA24125@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.