From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] console: Implement pre-console buffer
Date: Tue, 30 Aug 2011 15:58:07 -0400 [thread overview]
Message-ID: <201108301558.08010.vapier@gentoo.org> (raw)
In-Reply-To: <20110830195238.CC16118C46FE@gemini.denx.de>
On Tuesday, August 30, 2011 15:52:38 Wolfgang Denk wrote:
> Simon Glass wrote:
> > > +#define CIRC_BUF_IDX(idx) ((idx) % CONFIG_PRE_CON_BUF_SZ)
> >
> > The division here sticks in the craw, but unless we go with
>
> Does it? Why?
>
> > CONFIG_PRE_CON_BUF_SZ_LOG2 then I don't see an easy way around it, and
> > since this is serial output we can't honestly claim to worry much
> > about performance.
>
> Please see my previous posting
> (http://article.gmane.org/gmane.comp.boot-loaders.u-boot/106810)
>
> I don't think 3 additional addembler instructions really play a big
> role here.
i'm pretty sure if you define CONFIG_PRE_CON_BUF_SZ as a power of 2 value, you
get nice & simple assembly code. so if the generated code is undesirable,
pick a CONFIG value that is power-of-2 ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110830/a22cef35/attachment.pgp
next prev parent reply other threads:[~2011-08-30 19:58 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 12:14 [U-Boot] [PATCH 0/2] console: Squelch and pre-console buffer Graeme Russ
2011-08-29 12:14 ` [U-Boot] [PATCH 1/2] console: Squelch pre-console output in console functions Graeme Russ
2011-08-30 17:16 ` Mike Frysinger
2011-08-30 19:01 ` Wolfgang Denk
2011-09-21 23:21 ` Simon Glass
2011-10-01 19:54 ` Wolfgang Denk
2011-08-29 12:14 ` [U-Boot] [PATCH 2/2] console: Implement pre-console buffer Graeme Russ
2011-08-30 12:49 ` [U-Boot] [PATCH V2] " Graeme Russ
2011-08-30 17:19 ` Mike Frysinger
2011-08-30 19:45 ` Simon Glass
2011-08-30 19:52 ` Wolfgang Denk
2011-08-30 19:58 ` Mike Frysinger [this message]
2011-08-30 20:08 ` Wolfgang Denk
2011-08-30 20:18 ` Simon Glass
2011-08-30 20:57 ` Wolfgang Denk
2011-08-30 21:02 ` Simon Glass
2011-08-30 23:00 ` Graeme Russ
2011-08-30 23:39 ` Graeme Russ
2011-08-31 2:46 ` Mike Frysinger
2011-08-30 20:07 ` Simon Glass
2011-08-31 12:35 ` [U-Boot] (no subject) Graeme Russ
2011-08-31 12:38 ` Graeme Russ
2011-08-31 12:58 ` [U-Boot] [PATCH V4] console: Implement pre-console buffer Graeme Russ
2011-08-31 15:09 ` Mike Frysinger
2011-08-31 21:15 ` Graeme Russ
2011-08-31 21:33 ` Mike Frysinger
2011-08-31 21:59 ` Graeme Russ
2011-08-31 22:44 ` Mike Frysinger
2011-08-31 22:51 ` Graeme Russ
2011-08-31 16:58 ` Simon Glass
2011-08-31 19:18 ` Wolfgang Denk
2011-08-31 20:05 ` Simon Glass
2011-08-31 20:22 ` Mike Frysinger
2011-08-31 20:26 ` Simon Glass
2011-09-01 10:48 ` [U-Boot] [PATCH V5] " Graeme Russ
2011-09-01 10:52 ` Graeme Russ
2011-09-01 14:02 ` Mike Frysinger
2011-09-01 18:51 ` Simon Glass
2011-09-01 23:34 ` Graeme Russ
2011-09-02 2:41 ` Mike Frysinger
2011-09-02 2:58 ` Simon Glass
2011-09-21 23:18 ` Simon Glass
2011-10-04 5:30 ` Simon Glass
2011-10-05 18:50 ` Wolfgang Denk
2011-09-26 22:50 ` [U-Boot] [PATCH V4] " Vadim Bendebury
2011-09-27 11:22 ` Graeme Russ
2011-09-27 14:55 ` Vadim Bendebury
2011-09-29 23:15 ` Graeme Russ
2011-09-29 23:39 ` Vadim Bendebury
2011-09-29 23:47 ` Graeme Russ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108301558.08010.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.