From: Olaf Hering <olaf@aepfle.de>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 2/2] Load gntdev and evtchn if they're modular. [and 1 more messages]
Date: Tue, 30 Aug 2011 20:12:21 +0200 [thread overview]
Message-ID: <20110830181221.GB10090@aepfle.de> (raw)
In-Reply-To: <20061.5070.515745.853827@mariner.uk.xensource.com>
On Tue, Aug 30, Ian Jackson wrote:
> > +# run this script only in dom0:
> > +# no capabilities file in xenlinux kernel
> > +if ! test -f /proc/xen/capabilities ; then
> > + exit 0
> > +fi
> > +# empty capabilities file in pv_ops kernel
> > if ! grep -q "control_d" /proc/xen/capabilities ; then
> > exit 0
> > fi
>
> If /proc/xen/capabilities is missing, what does it mean ?
It means a domU with xenlinux PV drivers loaded, in that case the script
has to do nothing.
> kernels really not provide that file ? Also these two ifs would be
> better combined.
How would that look like? First the file is not there, so grep will
print an error - thats what my patch tries to fix.
Second the file is there and may indicate a dom0.
Olaf
next prev parent reply other threads:[~2011-08-30 18:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 7:11 [PATCH] hotplug: update xencommons script to run only when needed Olaf Hering
2011-08-25 15:15 ` Ian Jackson
2011-08-25 15:24 ` Olaf Hering
2011-08-25 15:34 ` Ian Jackson
2011-08-20 0:49 ` [PATCH 2/2] Load gntdev and evtchn if they're modular Jeremy Fitzhardinge
2011-08-26 9:10 ` [PATCH v2] hotplug: update xencommons script to run only when needed Olaf Hering
2011-08-30 16:46 ` [PATCH 2/2] Load gntdev and evtchn if they're modular. [and 1 more messages] Ian Jackson
2011-08-30 18:12 ` Olaf Hering [this message]
2011-08-31 16:02 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110830181221.GB10090@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Jackson@eu.citrix.com \
--cc=jeremy@goop.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.