From: Johannes Weiner <jweiner@redhat.com>
To: Viktor Rosendahl <viktor.rosendahl@nokia.com>
Cc: linux-mm@kvack.org,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Michal Hocko <mhocko@suse.cz>
Subject: Re: [PATCH] Enable OOM when moving processes between cgroups?
Date: Wed, 31 Aug 2011 19:54:22 +0200 [thread overview]
Message-ID: <20110831175422.GB21571@redhat.com> (raw)
In-Reply-To: <1314811941-14587-1-git-send-email-viktor.rosendahl@nokia.com>
On Wed, Aug 31, 2011 at 08:32:21PM +0300, Viktor Rosendahl wrote:
> Hello,
>
> I wonder if there is a specific reason why the OOM killer hasn't been enabled
> in the mem_cgroup_do_precharge() function in mm/memcontrol.c ?
>
> In my testing (2.6.32 kernel with some backported cgroups patches), it improves
> the case when there isn't room for the task in the target cgroup.
Tasks are moved directly on behalf of a request from userspace. We
would much prefer denying that single request than invoking the
oom-killer on the whole group.
Quite a lot changed in the trycharge-reclaim-retry path since 2009.
Nowadays, charging is retried as long as reclaim is making any
progress at all, so I don't see that it would give up moving a task
too lightly, even without the extra OOM looping.
Is there any chance you could retry with a more recent kernel?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-08-31 17:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 17:32 [PATCH] Enable OOM when moving processes between cgroups? Viktor Rosendahl
2011-08-31 17:54 ` Johannes Weiner [this message]
2011-09-01 0:02 ` KAMEZAWA Hiroyuki
2011-09-01 0:13 ` Daisuke Nishimura
2011-09-02 11:34 ` Viktor Rosendahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110831175422.GB21571@redhat.com \
--to=jweiner@redhat.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=viktor.rosendahl@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.