From: Oleg Nesterov <oleg@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Paul Menage <paul@paulmenage.org>,
containers@lists.linux-foundation.org,
linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH pm-freezer 1/4] cgroup_freezer: fix freezer->state setting bug in freezer_change_state()
Date: Wed, 31 Aug 2011 20:08:58 +0200 [thread overview]
Message-ID: <20110831180858.GA10725@redhat.com> (raw)
In-Reply-To: <20110831102100.GA2828@mtj.dyndns.org>
On 08/31, Tejun Heo wrote:
>
> I'm in the process of moving and can only use a quite old laptop. I
> tested compile but couldn't really do much else, so please proceed
> with caution. Oleg, can you please ack the patches if you agree with
> the updated versions?
Everything looks fine. But I am already sleeping now ;)
Rafael, Tejun, I'll try to re-read 1-4 tomorrow. I do not expect I'll
find something interesting, just I am paranoid.
Looks like, 1/4 could have an additional note in the changelog, with
this patch we avoid the unnecessary try_to_freeze_cgroup() and this
looks like a win to me...
Oleg.
next prev parent reply other threads:[~2011-08-31 18:12 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 10:21 [PATCH pm-freezer 1/4] cgroup_freezer: fix freezer->state setting bug in freezer_change_state() Tejun Heo
2011-08-31 10:21 ` [PATCH pm-freezer 2/4] freezer: set PF_NOFREEZE on a dying task right before TASK_DEAD " Tejun Heo
2011-08-31 10:21 ` Tejun Heo
2011-08-31 10:22 ` [PATCH pm-freezer 3/4] freezer: restructure __refrigerator() Tejun Heo
[not found] ` <20110831102210.GC2828-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2011-08-31 10:22 ` [PATCH pm-freezer 4/4] freezer: use lock_task_sighand() in fake_signal_wake_up() Tejun Heo
2011-09-02 17:08 ` [PATCH pm-freezer 3/4] freezer: restructure __refrigerator() Oleg Nesterov
2011-08-31 10:22 ` [PATCH pm-freezer 4/4] freezer: use lock_task_sighand() in fake_signal_wake_up() Tejun Heo
2011-08-31 10:22 ` Tejun Heo
2011-09-02 17:08 ` [PATCH pm-freezer 3/4] freezer: restructure __refrigerator() Oleg Nesterov
2011-09-02 17:08 ` Oleg Nesterov
2011-08-31 10:22 ` Tejun Heo
[not found] ` <20110831102143.GB2828-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2011-08-31 10:22 ` Tejun Heo
2011-08-31 18:08 ` [PATCH pm-freezer 1/4] cgroup_freezer: fix freezer->state setting bug in freezer_change_state() Oleg Nesterov
2011-08-31 18:08 ` Oleg Nesterov [this message]
2011-09-02 0:42 ` Matt Helsley
[not found] ` <20110831102100.GA2828-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2011-08-31 10:21 ` [PATCH pm-freezer 2/4] freezer: set PF_NOFREEZE on a dying task right before TASK_DEAD " Tejun Heo
2011-08-31 18:08 ` [PATCH pm-freezer 1/4] cgroup_freezer: fix freezer->state " Oleg Nesterov
2011-09-02 0:42 ` Matt Helsley
2011-09-02 0:42 ` Matt Helsley
2011-09-02 2:50 ` Tejun Heo
2011-09-02 2:50 ` Tejun Heo
2011-09-02 16:58 ` Oleg Nesterov
[not found] ` <20110902004231.GF1919-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2011-09-02 2:50 ` Tejun Heo
2011-09-02 16:58 ` Oleg Nesterov
2011-09-02 16:58 ` Oleg Nesterov
[not found] ` <20110902165839.GA7478-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-09-02 17:08 ` Tejun Heo
2011-09-02 18:31 ` Matt Helsley
2011-09-02 17:08 ` Tejun Heo
2011-09-02 17:15 ` Oleg Nesterov
[not found] ` <20110902171517.GA8247-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-09-02 17:31 ` Tejun Heo
2011-09-02 17:31 ` Tejun Heo
2011-09-02 17:31 ` Tejun Heo
[not found] ` <20110902170844.GJ2752-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2011-09-02 17:15 ` Oleg Nesterov
2011-09-02 17:30 ` Oleg Nesterov
2011-09-02 17:30 ` Oleg Nesterov
2011-09-02 17:15 ` Oleg Nesterov
2011-09-02 17:30 ` Oleg Nesterov
2011-09-02 17:08 ` Tejun Heo
2011-09-02 18:31 ` Matt Helsley
2011-09-02 18:31 ` Matt Helsley
-- strict thread matches above, loose matches on Subject: below --
2011-08-31 10:21 Tejun Heo
2011-08-31 10:21 Tejun Heo
2011-08-29 14:04 Tejun Heo
2011-08-29 14:04 Tejun Heo
2011-08-29 16:00 ` Oleg Nesterov
2011-08-29 16:00 ` Oleg Nesterov
[not found] ` <20110829140418.GB18871-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2011-08-29 16:00 ` Oleg Nesterov
2011-08-29 14:04 Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110831180858.GA10725@redhat.com \
--to=oleg@redhat.com \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=paul@paulmenage.org \
--cc=rjw@sisk.pl \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.