[U-Boot] [PATCH 3/7] Add timing information to printf's for use with bootgraph.pl

[Mike Frysinger <vapier@gentoo.org>]

On Wednesday, August 31, 2011 18:20:57 Andrew Murray wrote:
>  	va_list args;
>  	uint i;
>  	char printbuffer[CONFIG_SYS_PBSIZE];
> +	char *buf = printbuffer;
> 
>  	va_start(args, fmt);
> 
> +#if defined(CONFIG_BOOT_TRACE)
> +	unsigned long long ticks = get_ticks();
> +	int secs = ticks / get_tbclk();
> +	int msec = ((ticks * 1000000) / get_tbclk()) - (secs * 1000000);
> +
> +	i += sprintf(buf, "[%5lu.%06lu] ", secs, msec);
> +	buf += i;
> +#endif
> +
>  	/* For this to work, printbuffer must be larger than
>  	 * anything we ever want to print.
>  	 */
> -	i = vsprintf(printbuffer, fmt, args);
> +	i += vsprintf(buf, fmt, args);
>  	va_end(args);

NAK for a few reasons:
 - i dont see how this could possibly compile warning free
 - you never initialize "i", only added to it
 - you call va_start() inbetween variable decls
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110831/cbac9de1/attachment.pgp