From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] net: ll_temac: Add LL TEMAC driver to u-boot
Date: Wed, 31 Aug 2011 22:01:59 +0200 [thread overview]
Message-ID: <201108312201.59960.marek.vasut@gmail.com> (raw)
In-Reply-To: <201108311526.27959.vapier@gentoo.org>
On Wednesday, August 31, 2011 09:26:27 PM Mike Frysinger wrote:
> On Tuesday, August 30, 2011 08:05:18 Michal Simek wrote:
> > + volatile struct temac_reg *regs = priv->regs;
> > +
> > + regs->lsw = (phy_addr << 5) | reg_addr;
> > + regs->ctl = MIIMAI | (emac << 10);
>
> you should still be going through read/write i/o helper funcs rather than
> relying on the volatile markings
Oh, I didn't comment on the TEMAC. I'll have to go through it.
Cheers
>
> the rest looks sane
> -mike
next prev parent reply other threads:[~2011-08-31 20:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-30 12:05 [U-Boot] [PATCH v2] net: ll_temac: Add LL TEMAC driver to u-boot Michal Simek
2011-08-30 12:05 ` [U-Boot] [PATCH] net: axi_ethernet: Add " Michal Simek
2011-08-31 12:19 ` Marek Vasut
2011-08-31 14:46 ` Michal Simek
2011-08-31 15:19 ` Marek Vasut
2011-09-01 7:17 ` Michal Simek
2011-09-01 8:18 ` Marek Vasut
2011-09-01 8:55 ` Michal Simek
2011-09-01 10:07 ` Marek Vasut
2011-09-01 11:04 ` Michal Simek
2011-09-01 12:47 ` Wolfgang Denk
2011-08-31 20:13 ` Wolfgang Denk
2011-08-31 19:24 ` Mike Frysinger
2011-09-01 6:52 ` Michal Simek
2011-08-31 19:26 ` [U-Boot] [PATCH v2] net: ll_temac: Add LL TEMAC " Mike Frysinger
2011-08-31 20:01 ` Marek Vasut [this message]
2011-09-01 9:21 ` Michal Simek
2011-08-31 21:52 ` Marek Vasut
2011-09-01 11:11 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108312201.59960.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.