diff for duplicates of <20110901043806.GA25878@ericsson.com> diff --git a/a/1.txt b/N1/1.txt index 5a44602..e726816 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -25,7 +25,7 @@ On Wed, Aug 31, 2011 at 01:25:10PM -0400, Keerthy wrote: > +++ b/Documentation/hwmon/omap_temp_sensor > @@ -0,0 +1,26 @@ > +Kernel driver omap_temp_sensor -> +============================== +> +=============== > + > +Supported chips: > + * Texas Instruments OMAP4460 @@ -362,8 +362,7 @@ Why int here ? > + /* write the new t_cold value */ > + reg_val = omap_temp_sensor_readl(temp_sensor, > + temp_sensor->registers->bgap_threshold); -> + reg_val &= -> + ~temp_sensor->registers->threshold_tcold_mask; +> + reg_val &> + ~temp_sensor->registers->threshold_tcold_mask; > + reg_val |= cold << > + __ffs(temp_sensor->registers->threshold_tcold_mask); > + omap_temp_sensor_writel(temp_sensor, reg_val, @@ -371,11 +370,11 @@ Why int here ? > + t_cold = cold; > + } > + - t_hot == cold: t_hot will be equal to t_cold + t_hot = cold: t_hot will be equal to t_cold t_hot > t_colt: t_hot > t_cold, any difference - t_hot < t_cold: t_cold == t_hot - NEG_HYST_VAL + t_hot < t_cold: t_cold = t_hot - NEG_HYST_VAL -Seems to be inconsistent, and it seems that the condition t_hot == t_cold can still occur +Seems to be inconsistent, and it seems that the condition t_hot = t_cold can still occur (which you mentioned earlier would be invalid). If you want to define a minimum hysteresis, you should enforce it by modifying the if statement. @@ -401,8 +400,7 @@ you should enforce it by modifying the if statement. > + /* write the new t_hot value */ > + reg_val = omap_temp_sensor_readl(temp_sensor, > + temp_sensor->registers->bgap_threshold); -> + reg_val &= -> + ~temp_sensor->registers->threshold_thot_mask; +> + reg_val &> + ~temp_sensor->registers->threshold_thot_mask; > + reg_val |= (hot << > + __ffs(temp_sensor->registers->threshold_thot_mask)); > + omap_temp_sensor_writel(temp_sensor, reg_val, @@ -841,7 +839,7 @@ No iounmap in this case. > + goto clken_err; > + > + clk_rate = clk_round_rate(temp_sensor->clock, max_freq); -> + if (clk_rate < min_freq || clk_rate == 0xffffffff) { +> + if (clk_rate < min_freq || clk_rate = 0xffffffff) { > + ret = -ENODEV; > + goto clken_err; > + } @@ -948,8 +946,7 @@ Sure you don't want to disable the interrupts before freeing the irq ? > + temp_sensor->registers->bgap_counter); > + temp_sensor->bg_threshold = omap_temp_sensor_readl(temp_sensor, > + temp_sensor->registers->bgap_threshold); -> + temp_sensor->temp_sensor_tshut_threshold = -> + omap_temp_sensor_readl(temp_sensor, +> + temp_sensor->temp_sensor_tshut_threshold > + omap_temp_sensor_readl(temp_sensor, > + temp_sensor->registers->thsut_threshold); > +} > + @@ -1059,4 +1056,9 @@ Sure you don't want to disable the interrupts before freeing the irq ? > +MODULE_AUTHOR("J Keerthy <j-keerthy@ti.com>"); > -- > 1.7.0.4 -> +> + +_______________________________________________ +lm-sensors mailing list +lm-sensors@lm-sensors.org +http://lists.lm-sensors.org/mailman/listinfo/lm-sensors diff --git a/a/content_digest b/N1/content_digest index c7cb79c..777cfff 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,8 @@ "ref\01314811510-15595-1-git-send-email-j-keerthy@ti.com\0" "ref\01314811510-15595-7-git-send-email-j-keerthy@ti.com\0" "From\0Guenter Roeck <guenter.roeck@ericsson.com>\0" - "Subject\0Re: [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver\0" - "Date\0Wed, 31 Aug 2011 21:38:06 -0700\0" + "Subject\0Re: [lm-sensors] [PATCH 6/6 V4] hwmon: OMAP4: On die temperature\0" + "Date\0Thu, 01 Sep 2011 04:38:06 +0000\0" "To\0Keerthy <j-keerthy@ti.com>\0" "Cc\0linux-omap@vger.kernel.org <linux-omap@vger.kernel.org>" Jean Delvare <khali@linux-fr.org> @@ -36,7 +36,7 @@ "> +++ b/Documentation/hwmon/omap_temp_sensor\n" "> @@ -0,0 +1,26 @@\n" "> +Kernel driver omap_temp_sensor\n" - "> +==============================\n" + "> +===============\n" "> +\n" "> +Supported chips:\n" "> + * Texas Instruments OMAP4460\n" @@ -373,8 +373,7 @@ "> + /* write the new t_cold value */\n" "> + reg_val = omap_temp_sensor_readl(temp_sensor,\n" "> + temp_sensor->registers->bgap_threshold);\n" - "> + reg_val &=\n" - "> + ~temp_sensor->registers->threshold_tcold_mask;\n" + "> + reg_val &> + ~temp_sensor->registers->threshold_tcold_mask;\n" "> + reg_val |= cold <<\n" "> + __ffs(temp_sensor->registers->threshold_tcold_mask);\n" "> + omap_temp_sensor_writel(temp_sensor, reg_val,\n" @@ -382,11 +381,11 @@ "> + t_cold = cold;\n" "> + }\n" "> +\n" - "\tt_hot == cold: t_hot will be equal to t_cold\n" + "\tt_hot = cold: t_hot will be equal to t_cold\n" "\tt_hot > t_colt: t_hot > t_cold, any difference\n" - "\tt_hot < t_cold: t_cold == t_hot - NEG_HYST_VAL\n" + "\tt_hot < t_cold: t_cold = t_hot - NEG_HYST_VAL\n" "\n" - "Seems to be inconsistent, and it seems that the condition t_hot == t_cold can still occur \n" + "Seems to be inconsistent, and it seems that the condition t_hot = t_cold can still occur \n" "(which you mentioned earlier would be invalid). If you want to define a minimum hysteresis,\n" "you should enforce it by modifying the if statement.\n" "\n" @@ -412,8 +411,7 @@ "> + /* write the new t_hot value */\n" "> + reg_val = omap_temp_sensor_readl(temp_sensor,\n" "> + temp_sensor->registers->bgap_threshold);\n" - "> + reg_val &=\n" - "> + ~temp_sensor->registers->threshold_thot_mask;\n" + "> + reg_val &> + ~temp_sensor->registers->threshold_thot_mask;\n" "> + reg_val |= (hot <<\n" "> + __ffs(temp_sensor->registers->threshold_thot_mask));\n" "> + omap_temp_sensor_writel(temp_sensor, reg_val,\n" @@ -852,7 +850,7 @@ "> + goto clken_err;\n" "> +\n" "> + clk_rate = clk_round_rate(temp_sensor->clock, max_freq);\n" - "> + if (clk_rate < min_freq || clk_rate == 0xffffffff) {\n" + "> + if (clk_rate < min_freq || clk_rate = 0xffffffff) {\n" "> + ret = -ENODEV;\n" "> + goto clken_err;\n" "> + }\n" @@ -959,8 +957,7 @@ "> + temp_sensor->registers->bgap_counter);\n" "> + temp_sensor->bg_threshold = omap_temp_sensor_readl(temp_sensor,\n" "> + temp_sensor->registers->bgap_threshold);\n" - "> + temp_sensor->temp_sensor_tshut_threshold =\n" - "> + omap_temp_sensor_readl(temp_sensor,\n" + "> + temp_sensor->temp_sensor_tshut_threshold > + omap_temp_sensor_readl(temp_sensor,\n" "> + temp_sensor->registers->thsut_threshold);\n" "> +}\n" "> +\n" @@ -1070,6 +1067,11 @@ "> +MODULE_AUTHOR(\"J Keerthy <j-keerthy@ti.com>\");\n" "> --\n" "> 1.7.0.4\n" - > + "> \n" + "\n" + "_______________________________________________\n" + "lm-sensors mailing list\n" + "lm-sensors@lm-sensors.org\n" + http://lists.lm-sensors.org/mailman/listinfo/lm-sensors -cb0f2e743ae8dabba479484f5c49e7de5ae5c99462b0128c4487dff3b470757c +204c4779e055fd6c503a05cb05e020ef7bcdb0e0d6679102dae6335cc94a9a1e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.