From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Thu, 1 Sep 2011 10:16:15 -0400 Subject: [U-Boot] [PATCH v11 1/9] nds32: add header files support for nds32 In-Reply-To: <1314856371-9857-1-git-send-email-macpaul@andestech.com> References: <1304342712-17120-10-git-send-email-macpaul@andestech.com> <1314856371-9857-1-git-send-email-macpaul@andestech.com> Message-ID: <201109011016.17179.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday, September 01, 2011 01:52:42 Macpaul Lin wrote: > --- /dev/null > +++ b/arch/nds32/include/asm/memory.h > +#ifndef __ASM_NDS_MEMORY_H > +#define __ASM_NDS_MEMORY_H > + > +#endif /* __ASM_NDS_MEMORY_H */ this header doesnt define anything, and common code doesnt require asm/memory.h, so looks like you should just punt this > --- /dev/null > +++ b/arch/nds32/include/asm/u-boot.h > > +#include > ... > +typedef struct bd_info { > ... > + env_t *bi_env; this is pretty unusual. why do you need a board-specific point to the env ? no other arch needs this ... -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20110901/f8df99b4/attachment.pgp