From: Alex Netes <alexne-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Albert Chu <chu11-i2BcT+NCU+M@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [opensm] [PATCH] Fix invalid error check, which lead to segfault
Date: Fri, 2 Sep 2011 09:46:24 +0300 [thread overview]
Message-ID: <20110902064208.GA1998@calypso> (raw)
In-Reply-To: <1314919847.25283.446.camel-akkeaxHeDKRliZ7u+bvwcg@public.gmane.org>
Hi Al,
On 16:30 Thu 01 Sep , Albert Chu wrote:
> This patch fixes a bug from:
>
> commit 350c6e49fe3ee492b397346633dee76d3cad9ade
> Author: Alex Netes <alexne-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Date: Mon Mar 7 10:03:59 2011 +0000
>
> opensm: fixed potential memory leak in osm_ucast_ftree()
>
> Need to free all the allocated variables in case of error.
>
> The invalid error check would lead to sw_create() always returning NULL,
> leading to fabric_add_sw() never adding a switch to sw_tbl, leading to
> fabric_get_sw_by_guid() always returning NULL (i.e. can't find switch),
> leading to rank_leaf_switches() segfaulting.
>
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-09-02 6:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 23:30 [opensm] [PATCH] Fix invalid error check, which lead to segfault Albert Chu
[not found] ` <1314919847.25283.446.camel-akkeaxHeDKRliZ7u+bvwcg@public.gmane.org>
2011-09-02 6:46 ` Alex Netes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110902064208.GA1998@calypso \
--to=alexne-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=chu11-i2BcT+NCU+M@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.