From: Dan Carpenter <error27@gmail.com>
To: Gerard Snitselaar <dev@snitselaar.org>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8187se: Fix whitespace issues
Date: Fri, 2 Sep 2011 11:04:57 +0300 [thread overview]
Message-ID: <20110902080457.GE2430@shale.localdomain> (raw)
In-Reply-To: <1314949913-13090-1-git-send-email-dev@snitselaar.org>
On Fri, Sep 02, 2011 at 12:51:53AM -0700, Gerard Snitselaar wrote:
> #define MAX_LD_SLOT_NUM 10
> -#define KEEP_ALIVE_INTERVAL 20 // in seconds.
> +#define KEEP_ALIVE_INTERVAL 20 // in seconds.
> #define CHECK_FOR_HANG_PERIOD 2 //be equal to watchdog check time
> #define DEFAULT_KEEP_ALIVE_LEVEL 1
> #define DEFAULT_SLOT_NUM 2
It would be better if the 1 and 2 were lined up.
> @@ -591,14 +591,14 @@ typedef struct r8180_priv
> int ForcedDataRate; // Force Data Rate. 0: Auto, 0x02: 1M ~ 0x6C: 54M.)
> u32 NumTxUnicast; //YJ,add,080828,for keep alive
> u8 keepAliveLevel; //YJ,add,080828,for KeepAlive
> - unsigned long NumTxOkTotal;
> + unsigned long NumTxOkTotal;
> u16 LastRetryCnt;
> u16 LastRetryRate;
> unsigned long LastTxokCnt;
> unsigned long LastRxokCnt;
> u16 CurrRetryCnt;
> unsigned long LastTxOKBytes;
> - unsigned long NumTxOkBytesTotal;
> + unsigned long NumTxOkBytesTotal;
> u8 LastFailTxRate;
> long LastFailTxRateSS;
> u8 FailTxRateCount;
These are all higgledy-piggledy.
> @@ -579,7 +579,7 @@ StaRateAdaptive87SE(
> u32 TxThroughput;
> long CurrSignalStrength;
> bool bUpdateInitialGain = false;
> - u8 u1bOfdm=0, u1bCck = 0;
> + u8 u1bOfdm=0, u1bCck = 0;
^^^
Spaces around the '=' char.
> @@ -846,7 +846,7 @@ StaRateAdaptive87SE(
> bTryDown = true;
> priv->TryDownCountLowData += TryDownTh;
> }
> - else if ( (CurrRetryRate<20) && (priv->LastRetryRate<21)) //TO DO: need to consider (RSSI)
> + else if ( (CurrRetryRate<20) && (priv->LastRetryRate<21)) //TO DO: need to consider (RSSI)
^ ^^^ ^^^
Delete extra space, add spaces around the '<' chars.
> --- a/drivers/staging/rtl8187se/r8185b_init.c
> +++ b/drivers/staging/rtl8187se/r8185b_init.c
> @@ -172,7 +172,7 @@ if (offset == PhyAddr) {
> */
> /* NdisAcquireSpinLock( &(pDevice->IoSpinLock) ); */
>
> - for (idx = 0; idx < 30; idx++) {
> + for (idx = 0; idx < 30; idx++) {
^
Delete the second space here.
regards,
dan carpenter
prev parent reply other threads:[~2011-09-02 8:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 7:51 [PATCH] Staging: rtl8187se: Fix whitespace issues Gerard Snitselaar
2011-09-02 8:04 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110902080457.GE2430@shale.localdomain \
--to=error27@gmail.com \
--cc=dev@snitselaar.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.