From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org, joerg.roedel@amd.com, aliguori@us.ibm.com,
rth@twiddle.net, agraf@suse.de, eduard.munteanu@linux360.ro
Subject: Re: [Qemu-devel] [PATCH 01/10] Add stub functions for PCI device models to do PCI DMA
Date: Mon, 5 Sep 2011 10:55:59 +0300 [thread overview]
Message-ID: <20110905075559.GA16038@redhat.com> (raw)
In-Reply-To: <20110902043825.GX11906@yookeroo.fritz.box>
On Fri, Sep 02, 2011 at 02:38:25PM +1000, David Gibson wrote:
> > I'd prefer the stubs to be inline. Not just as an optimization:
> > it also makes it easier to grok what goes on in the common
> > no-iommu case.
>
> To elaborate on my earlier mail. The problem with making them inlines
> is that the cpu_physical_*() functions then appear in pci.h, which is
> used in pci.c amongst other places that are included in
> libhw32/libhw64, where those functions are poisoned.
Hmm, how are they poisoned?
I thought almost all devices currently use cpu_physical_*()?
For example, e1000 uses cpu_physical_memory_write and
it seems to get included in libhw32/libhw64 without issues.
> --
> David Gibson | I'll have my music baroque, and my code
> david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
> | _way_ _around_!
> http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2011-09-05 7:55 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 5:00 [Qemu-devel] [0/10] Preliminary work for IOMMU emulation support; the easy bits David Gibson
2011-09-01 5:00 ` [Qemu-devel] [PATCH 01/10] Add stub functions for PCI device models to do PCI DMA David Gibson
2011-09-01 15:35 ` Michael S. Tsirkin
2011-09-02 0:39 ` David Gibson
2011-09-02 4:38 ` David Gibson
2011-09-05 7:55 ` Michael S. Tsirkin [this message]
2011-09-01 15:55 ` Anthony Liguori
2011-09-01 16:03 ` Avi Kivity
2011-09-01 16:05 ` Anthony Liguori
2011-09-01 16:11 ` Avi Kivity
2011-09-01 16:32 ` Anthony Liguori
2011-09-02 8:35 ` Avi Kivity
2011-09-03 12:25 ` Blue Swirl
2011-09-02 0:38 ` David Gibson
2011-09-02 8:37 ` Avi Kivity
2011-09-03 3:04 ` Eduard - Gabriel Munteanu
2011-09-02 4:40 ` David Gibson
2011-09-03 1:16 ` Richard Henderson
2011-09-23 16:37 ` Anthony Liguori
2011-09-01 5:00 ` [Qemu-devel] [PATCH 02/10] rtl8139: Use PCI DMA stub functions David Gibson
2011-09-01 5:00 ` [Qemu-devel] [PATCH 03/10] eepro100: " David Gibson
2011-09-01 5:00 ` [Qemu-devel] [PATCH 04/10] ac97: " David Gibson
2011-09-01 5:00 ` [Qemu-devel] [PATCH 05/10] es1370: " David Gibson
2011-09-01 5:00 ` [Qemu-devel] [PATCH 06/10] e1000: " David Gibson
2011-09-01 5:01 ` [Qemu-devel] [PATCH 07/10] lsi53c895a: " David Gibson
2011-09-01 5:01 ` [Qemu-devel] [PATCH 08/10] pcnet-pci: " David Gibson
2011-09-01 5:01 ` [Qemu-devel] [PATCH 09/10] usb-ohci: " David Gibson
2011-09-01 10:10 ` Gerd Hoffmann
2011-09-02 1:47 ` David Gibson
2011-09-01 5:01 ` [Qemu-devel] [PATCH 10/10] intel-hda: " David Gibson
2011-09-01 10:16 ` Gerd Hoffmann
2011-09-02 1:42 ` David Gibson
2011-09-01 11:33 ` [Qemu-devel] [0/10] Preliminary work for IOMMU emulation support; the easy bits Eduard - Gabriel Munteanu
2011-09-02 0:36 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110905075559.GA16038@redhat.com \
--to=mst@redhat.com \
--cc=agraf@suse.de \
--cc=aliguori@us.ibm.com \
--cc=eduard.munteanu@linux360.ro \
--cc=joerg.roedel@amd.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.