All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Claudio Takahasi <claudio.takahasi@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RFC BlueZ 02/11] Add set auto connect in device
Date: Mon, 5 Sep 2011 12:55:32 +0300	[thread overview]
Message-ID: <20110905095532.GA6735@dell.ger.corp.intel.com> (raw)
In-Reply-To: <1314999521-11261-3-git-send-email-claudio.takahasi@openbossa.org>

Hi Claudio,

On Fri, Sep 02, 2011, Claudio Takahasi wrote:
> +void btd_adapter_system_unlocked(struct btd_adapter *adapter)
> +{
> +	if (!adapter->up)
> +		return;
> +
> +	DBG("Unlocked");
> +
> +	g_slist_foreach(adapter->devices, set_auto_connect, NULL);
> +}

While the concept seems fine I think you've got the wrong name for the
function. You shouldn't assume that "system unlocked" is the only reason
for enabling auto-connect for the devices. It's as if you'd be pushing
policy into the core daemon ("if unlocked, then auto-connect"). Instead
the function should be named according to what it does, e.g.
btd_adapter_enable_auto_connect or btd_adapter_auto_connect_devices.

Johan

  reply	other threads:[~2011-09-05  9:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-02 21:38 [RFC BlueZ 00/11] Re-connections triggered by platform event Claudio Takahasi
2011-09-02 21:38 ` [RFC BlueZ 01/11] Remove timer to trigger connection attempts Claudio Takahasi
2011-09-02 21:38 ` [RFC BlueZ 02/11] Add set auto connect in device Claudio Takahasi
2011-09-05  9:55   ` Johan Hedberg [this message]
2011-09-05 13:47     ` Claudio Takahasi
2011-09-02 21:38 ` [RFC BlueZ 03/11] Add continuous connection attempt Claudio Takahasi
2011-09-02 21:38 ` [RFC BlueZ 04/11] Add checking if profiles are requesting connection Claudio Takahasi
2011-09-02 21:38 ` [RFC BlueZ 05/11] Add tracking of connect sources Claudio Takahasi
2011-09-02 21:38 ` [RFC BlueZ 06/11] Disable automatic connections after 3 minutes Claudio Takahasi
2011-09-02 21:38 ` [RFC BlueZ 07/11] Add display lock watcher on maemo6 plugin Claudio Takahasi
2011-09-02 21:38 ` [RFC BlueZ 08/11] Notify unlocked event when using " Claudio Takahasi
2011-09-02 21:38 ` [RFC BlueZ 09/11] Add automatic connect timeout config option Claudio Takahasi
2011-09-02 21:38 ` [RFC BlueZ 10/11] Add an interval between connection attempts Claudio Takahasi
2011-09-02 21:38 ` [RFC BlueZ 11/11] Enable re-connections when disconnected Claudio Takahasi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110905095532.GA6735@dell.ger.corp.intel.com \
    --to=johan.hedberg@gmail.com \
    --cc=claudio.takahasi@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.