From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752440Ab1IEKBw (ORCPT ); Mon, 5 Sep 2011 06:01:52 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56023 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752182Ab1IEKBo (ORCPT ); Mon, 5 Sep 2011 06:01:44 -0400 Date: Mon, 5 Sep 2011 12:01:41 +0200 From: Jan Kara To: Wu Fengguang Cc: Jan Kara , Jens Axboe , LKML , Andrew Morton Subject: Re: [PATCH 2/2] mm: Add comment explaining task state setting in bdi_forker_thread() Message-ID: <20110905100141.GA5466@quack.suse.cz> References: <1315004059-9844-1-git-send-email-jack@suse.cz> <1315004059-9844-3-git-send-email-jack@suse.cz> <20110904030551.GB16361@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110904030551.GB16361@localhost> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun 04-09-11 11:05:51, Wu Fengguang wrote: > > @@ -401,6 +401,13 @@ static int bdi_forker_thread(void *ptr) > > } > > > > spin_lock_bh(&bdi_lock); > > + /* > > + * In the following loop we are going to check whether we have > > + * some work to do without any synchronization with tasks > > + * waking us up to do work for them. So we have to set task > > + * state already here so that we don't miss wakeups coming > > s/already/early/ ? Thanks for review. We'd have to substitute 'already here' with 'early' for the sentence to make make sense. But frankly I don't see why one would be better than the other one... Honza > > Acked-by: Wu Fengguang > > > + * after we verify some condition. > > + */ > > set_current_state(TASK_INTERRUPTIBLE); > > > > list_for_each_entry(bdi, &bdi_list, bdi_list) { > > -- > > 1.7.1 -- Jan Kara SUSE Labs, CR