From: Alon Levy <alevy@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Yonit Halperin <yhalperi@redhat.com>,
qemu-devel@nongnu.org, spice-devel@freedesktop.org
Subject: Re: [Qemu-devel] [Spice-devel] [PATCH] server: don't call reds_stream_free from worker thread context
Date: Mon, 5 Sep 2011 13:47:00 +0300 [thread overview]
Message-ID: <20110905104700.GN27006@bow> (raw)
In-Reply-To: <4E649033.2040105@redhat.com>
On Mon, Sep 05, 2011 at 11:02:43AM +0200, Gerd Hoffmann wrote:
> Hi,
>
> >Hi,
> >RED_WORKER_MESSAGE_DISPLAY_DISCONNECT is not the only place that
> >triggers red_disconnect_channel (and as a result,
> >reds_stream_free(dispatcher->stream)). red_disconnect_channel is called
> >also when there is an error upon receive/send and also when timeouts
> >related to the client occur (e.g., in flush_display_commands).
>
> Ok.
>
> >We probably better make the dispatcher bi-directional, i.e., not only
> >push messages to the worker, but also listen.
>
> That sounds like a non-trivial thing.
>
> What does the master branch here btw? I had a brief look and saw
> that the code looks quite different here (probably due to the
> multiclient work).
>
I verified it still calls reds_stream_free from the worker thread, only
now the call itself is done in red_channel.c (via red_channel_disconnect
or something like that), which is called from red_worker.c
> cheers,
> Gerd
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
next prev parent reply other threads:[~2011-09-05 10:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 15:19 [Qemu-devel] [PATCH] server: don't call reds_stream_free from worker thread context Gerd Hoffmann
2011-09-02 19:27 ` [Qemu-devel] [Spice-devel] " Alon Levy
2011-09-04 8:43 ` Yonit Halperin
2011-09-05 9:02 ` Gerd Hoffmann
2011-09-05 10:47 ` Alon Levy [this message]
2011-09-05 13:29 ` Gerd Hoffmann
2011-09-05 13:44 ` Alon Levy
2011-09-05 13:45 ` Alon Levy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110905104700.GN27006@bow \
--to=alevy@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=spice-devel@freedesktop.org \
--cc=yhalperi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.