From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wu Fengguang Subject: Re: [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver Date: Mon, 5 Sep 2011 20:31:29 +0800 Message-ID: <20110905123128.GA31852@localhost> References: <20110902081428.GA19621@localhost> <20110903211510.GA11600@localhost> <20110905011400.GB24561@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: "Wang, Zhenyu Z" , "intel-gfx@lists.freedesktop.org" , "alsa-devel@alsa-project.org" , "dri-devel@lists.freedesktop.org" , Ben Skeggs , Jeremy Bush , Christopher White , "Fu, Michael" , "Bossart, Pierre-louis" List-Id: alsa-devel@alsa-project.org On Mon, Sep 05, 2011 at 07:04:50PM +0800, Chris Wilson wrote: > On Mon, 5 Sep 2011 09:14:00 +0800, Wu Fengguang wrote: > > On Sun, Sep 04, 2011 at 08:08:37PM +0800, Chris Wilson wrote: > > > On Sun, 4 Sep 2011 05:15:10 +0800, Wu Fengguang wrote: > > > This patch should be split between adding the core drm functionality to > > > build the ELD and the introduction of i915 support. > > > > OK. I didn't do this because I was not sure if it's OK to just add the > > drm_*() functions without any code to call them.. > > Right, we don't introduce new interfaces without users - but it is > acceptable to say "... which will be used by i915 in a following patch" if > you want to clarify the need for the interface. It just helps to > compartmentalize the damage should we find something goes horribly wrong > later. Sounds pretty reasonable. And the logical split may help make a bit easier to review :) Fengguang