All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] UBIFS: Change ubifsload to set the filesize variable
Date: Mon, 5 Sep 2011 17:04:45 +0200	[thread overview]
Message-ID: <201109051704.45430.marek.vasut@gmail.com> (raw)
In-Reply-To: <20110905142728.9F0E0140ABDF@gemini.denx.de>

On Monday, September 05, 2011 04:27:28 PM Wolfgang Denk wrote:
> Dear Marek Vasut,
> 
> In message <201109051512.48148.marek.vasut@gmail.com> you wrote:
> > > +	setenv("filesize", buf);
> > 
> > maybe you want to check set_local_var() too ?
> 
> Yes, we should clean up all these auto-generated environment variables
> one day.  But what you propose here is not a good approach:
> 
> (1) not all boards use the hush shell, and set_local_var() is only
>     available there.
> (2) if you make such a change, then you must make it everywhere, and
>     you must make sure not to break existent use of these things.
> 
> Both is definitely out of the scope of this patch.

You're definitelly right on this thing.

> 
> Best regards,
> 
> Wolfgang Denk

      reply	other threads:[~2011-09-05 15:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-05 11:03 [U-Boot] [PATCH] UBIFS: Change ubifsload to set the filesize variable Bastian Ruppert
2011-09-05 11:27 ` Wolfgang Denk
2011-09-05 13:03 ` [U-Boot] [PATCH v2] " Bastian Ruppert
2011-09-09 12:12   ` Detlev Zundel
2011-09-09 22:04   ` Wolfgang Denk
2011-09-09 22:43   ` [U-Boot] [PATCH] UBIFS: fix warning: format '%lX' expects type 'long unsigned int' Wolfgang Denk
2011-09-10 20:40     ` Wolfgang Denk
2011-09-05 13:12 ` [U-Boot] [PATCH] UBIFS: Change ubifsload to set the filesize variable Marek Vasut
2011-09-05 14:27   ` Wolfgang Denk
2011-09-05 15:04     ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201109051704.45430.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.