All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Allison Henderson <achender@linux.vnet.ibm.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 0/6 v7] ext4: fix 1k block bugs
Date: Tue, 6 Sep 2011 00:59:42 -0400	[thread overview]
Message-ID: <20110906045942.GA4059@thunk.org> (raw)
In-Reply-To: <1314750513-10045-1-git-send-email-achender@linux.vnet.ibm.com>

Allison,

Many, many thanks for your work on this patch series!!  It's clearly
been a very long slog.

I've pulled in the first three patches, since I think those are
clearly correct at this point.  One minor change I've made was I fixed
the spelling the flag, which I channged to
EXT4_DISCARD_PARTIAL_PG_ZERO_UNMAPPED.  (Sorry, but seeing MAPED
everywhere was just grating on my nerves.  :-)

I didn't want to apply your 4th patch in the series since we're
planning on reducing the usage of i_mutex in the fs/ext4 code proper,
as recommended by Christoph.  It wasn't immediately obvious to me
whether it was safe to apply any of the patches after #4, so for now
I've just merged in the first three, since they clearly fix real
problems that show up in xfstests.

Can you comment on whether patches #5, #6, and #7 depend on #4?

Thanks,

						- Ted

  parent reply	other threads:[~2011-09-06  4:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-31  0:28 [PATCH 0/6 v7] ext4: fix 1k block bugs Allison Henderson
2011-08-31  0:28 ` [PATCH 1/6 v7] ext4: Add new ext4_discard_partial_page_buffers routines Allison Henderson
2011-08-31  0:28 ` [PATCH 2/6 v7] ext4: fix xfstests 75, 112, 127 punch hole failure Allison Henderson
2011-08-31  0:28 ` [PATCH 3/6 v7] ext4: fix 2nd xfstests " Allison Henderson
2011-08-31  0:28 ` [PATCH 4/6 v7] ext4: Lock i_mutex for punch hole Allison Henderson
2011-08-31  0:31   ` Andreas Dilger
2011-08-31 18:49     ` Allison Henderson
2011-08-31 19:44       ` Andreas Dilger
2011-08-31  0:28 ` [PATCH 5/6 v7] ext4: fix fsx truncate failure Allison Henderson
2011-08-31  0:28 ` [PATCH 6/6 v7] ext4: fix partial page writes Allison Henderson
2011-09-06  4:59 ` Ted Ts'o [this message]
2011-09-06 16:38   ` [PATCH 0/6 v7] ext4: fix 1k block bugs Allison Henderson
2011-09-07 18:41     ` Allison Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110906045942.GA4059@thunk.org \
    --to=tytso@mit.edu \
    --cc=achender@linux.vnet.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.