From: Tejun Heo <tj@kernel.org>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: Jeff Garzik <jgarzik@pobox.com>, Alan Cox <alan@linux.intel.com>,
linux-ide@vger.kernel.org, tom.leiming@gmail.com
Subject: Re: [PATCH #upstream-fixes] libata: clear PIO pad area
Date: Wed, 7 Sep 2011 02:30:14 +0900 [thread overview]
Message-ID: <20110906173014.GL18425@mtj.dyndns.org> (raw)
In-Reply-To: <4E6656F5.1050901@ru.mvista.com>
On Tue, Sep 06, 2011 at 09:23:01PM +0400, Sergei Shtylyov wrote:
> >There were devices which puke on random garbage at the end of CDB and
>
> Note that ATAPI CDBs are always aligned to 4 bytes, so this path
> should never be hit when sending them.
Ah, okay, but still, let's just clear it. There's nothing to be
gained by not clearing several bytes there.
> >in general sending indeterministic garbage to external device is a bad
> >idea. It increases chance of problems which can be difficult to
> >reproduce and track down while gaining nothing.
>
> Problems with "don't care" padding bytes? Dunno...
Oh yeah, IIRC there were multiple devices which puked on "don't care"
garbage bytes in CDB. Don't underestimate the crappiness of cheap
ATAPI devices. :)
Thanks.
--
tejun
prev parent reply other threads:[~2011-09-06 17:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-06 4:09 [PATCH #upstream-fixes] libata: clear PIO pad area Tejun Heo
2011-09-06 10:06 ` Sergei Shtylyov
2011-09-06 11:16 ` Alan Cox
2011-09-06 16:58 ` Tejun Heo
2011-09-06 17:23 ` Sergei Shtylyov
2011-09-06 17:28 ` Sergei Shtylyov
2011-09-06 17:30 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110906173014.GL18425@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=alan@linux.intel.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@mvista.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.