From: Evgeniy Polyakov <zbr@ioremap.net>
To: Jan Weitzel <j.weitzel@phytec.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC] w1: Disable irqs in critical section
Date: Wed, 7 Sep 2011 21:50:59 +0400 [thread overview]
Message-ID: <20110907175059.GA12074@ioremap.net> (raw)
In-Reply-To: <1315385312-1176-1-git-send-email-j.weitzel@phytec.de>
On Wed, Sep 07, 2011 at 10:48:32AM +0200, Jan Weitzel (j.weitzel@phytec.de) wrote:
> Interrupting w1_delay in w1_read_bit results in missing the low level
> on the w1 line and receiving "1" instead of "0".
> Adding local_irq_save / local_irq_restore around the critical section
This means that CPU will be essentially stuck for 15 useconds for every
bit transferred, doesn't really look like a good idea.
Are you absolutely sure that missing bit is because of timings and not
some other bug?
--
Evgeniy Polyakov
next prev parent reply other threads:[~2011-09-07 17:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 8:48 [RFC] w1: Disable irqs in critical section Jan Weitzel
2011-09-07 17:50 ` Evgeniy Polyakov [this message]
2011-09-08 5:46 ` Jan Weitzel
2011-09-13 22:41 ` Andrew Morton
2011-09-14 12:23 ` Jan Weitzel
2011-09-14 19:45 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110907175059.GA12074@ioremap.net \
--to=zbr@ioremap.net \
--cc=j.weitzel@phytec.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.